test: disable unused Lombok integration in JUnit fixture - #1930
Merged
Changyong Gong (chagong) merged 1 commit intoSep 9, 2026
Conversation
Disable the bundled Lombok agent only in the JUnit test workspace, which has no Lombok dependency, to avoid upstream JDT indexing failures. Related: redhat-developer/vscode-java#4504 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Changyong Gong (chagong)
September 9, 2026 05:09
View session
There was a problem hiding this comment.
🟢 Approval recommended
The change is scoped to a single test fixture JSON setting, is valid/consistent with other fixture settings, and aligns with the stated workaround goal without impacting production behavior.
Pull request overview
Adjusts the JUnit test fixture workspace configuration to disable Lombok support specifically for that fixture, avoiding Lombok-agent indexing failures while keeping the Java language server in Standard launch mode.
Changes:
- Add
java.jdt.ls.lombokSupport.enabled: falseto the JUnit fixture workspace settings. - Preserve
java.server.launchMode: Standardin the same fixture.
File summaries
| File | Description |
|---|---|
| test/test-projects/junit/.vscode/settings.json | Disables Lombok support only for the JUnit fixture workspace while keeping Standard launch mode. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wenyt (wenytang-ms)
approved these changes
Sep 9, 2026
Changyong Gong (chagong)
deleted the
chagong-navigation-lombok-workaround
branch
September 9, 2026 05:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable
java.jdt.ls.lombokSupport.enabledonly in the JUnit fixture workspace, which has no Lombok dependency. Preservejava.server.launchMode: Standard.Workaround for redhat-developer/vscode-java#4504: the bundled Lombok agent in Java prerelease
1.57.2026090508still accessesConstructorDeclaration.constructorCall, removed by Eclipse JDT. This throwsNoSuchFieldErrorduring indexing, including for non-Lombok source, and leaves navigation searches without results. The regression was observed on macOS with that prerelease; it is not claimed to be intrinsically OS-specific.Only this fixture setting changes. Production navigation, existing assertions, dependency manifests, and users' Lombok support are unchanged. This does not repair the upstream incompatibility.
Validation
Controlled macOS jobs used the same pinned failing Java prerelease, VS Code
1.136.2, Node 20, Temurin 21, debugger0.59.2026072407, manifest, and original navigation source/assertions:NoSuchFieldError.The controlled workflow is intentionally marked failed because its negative-control job fails; the workaround job passes.
Local Windows validation:
npm run build-plugin,npm run vscode:prepublish, andnpm testpassed (150 main tests + 1 unmanaged-folder test).