Skip to content

fix(deps): remove direct lru-cache dependency - #1926

Open
dependabot[bot] wants to merge 3 commits into
mainfrom
dependabot/npm_and_yarn/lru-cache-11.5.2
Open

fix(deps): remove direct lru-cache dependency#1926
dependabot[bot] wants to merge 3 commits into
mainfrom
dependabot/npm_and_yarn/lru-cache-11.5.2

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Sep 7, 2026

Copy link
Copy Markdown
Contributor

The attempted lru-cache 7.18.3 to 11.5.2 update is replaced by removal of the direct runtime dependency.

lru-cache v11 requires Node 20, while this extension supports VS Code 1.88 (Node 18), and v9+ also removed the constructor import used here. The extension only needed a 32-entry cache with get and set, so this change preserves that behavior with a focused bounded LRU map, removes the obsolete type package and notices, and adds regression coverage for eviction order.

Bumps [lru-cache](https://github.com/isaacs/node-lru-cache) from 7.18.3 to 11.5.2.
- [Changelog](https://github.com/isaacs/node-lru-cache/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-lru-cache@v7.18.3...v11.5.2)

---
updated-dependencies:
- dependency-name: lru-cache
  dependency-version: 11.5.2
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Sep 7, 2026
Replace the narrow 32-entry cache usage with a local bounded LRU map so the extension retains VS Code 1.88 runtime compatibility.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@chagong Changyong Gong (chagong) changed the title chore(deps): bump lru-cache from 7.18.3 to 11.5.2 fix(deps): remove direct lru-cache dependency Sep 8, 2026
@chagong

Changyong Gong (chagong) commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Decision: NOT_MERGED

Dependabot PR Manager result

Repository: microsoft/vscode-java-test
Pull request: microsoft/vscode-java-test#1926fix(deps): remove direct lru-cache dependency
Update: lru-cache 7.18.3 -> removed and @types/lru-cache 7.10.10 -> removed, superseding the proposed major update to 11.5.2. Not security-related.

Safety assessment: The Dependabot starting commit and Copilot remediation head 3f31d79ed60058ddcb1c4e1524c721777c66cae4 are verified. The removal uses focused compatibility remediation with regression coverage, but dependency necessity and final risk gates were not re-evaluated because commit 2a82abbd4fa214957d8acc75052f160455e16f9b is human-authored and is not recorded as an update-branch merge in the authenticated manager’s provenance ledger.

Final state: Head 2a82abbd4fa214957d8acc75052f160455e16f9b; open, mergeable, merge state BEHIND, review decision REVIEW_REQUIRED. CI: 7 successful, 2 failed, 0 non-terminal. VSCode-Test-Runner-CI-Build and VSCode-Test-Runner-CI-Build (Build VSCode-Test-Runner-CI) are INDETERMINATE because the definitive provenance blocker stopped the audit before failure-log analysis.

Actions taken: Performed a read-only target, commit-identity, provenance, diff, review-thread, required-check, complete-check, and base-ancestry audit. No rebase, rerun, remediation, approval, or merge was attempted. Head SHA remained unchanged.

Reason: Human-authored merge commit 2a82abbd4fa214957d8acc75052f160455e16f9b cannot be recognized as an authorized update-branch merge because the existing provenance ledger contains no corresponding update record.

Next action: Manually review the unverified merge commit and failed Azure checks, then update the branch through an auditable operation before rerunning management.

Workflow run: https://github.com/chagong/JavaForge/actions/runs/34448998621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants