Bump @vscode/test-electron to 3.1.0 and move test VS Code pin to 1.131.0 - #14619
Merged
sean-mcmanus merged 2 commits intoJul 29, 2026
Merged
Conversation
…n macOS VS Code 1.110 renamed the macOS main binary from Contents/MacOS/Electron to the product name and later removed the compatibility symlink (microsoft/vscode#326502, 2026-07-20), so @vscode/test-electron <=3.0.0 — which hardcodes the Electron name — fails to launch downloaded stable builds on macOS with 'spawn .../Contents/MacOS/Electron ENOENT'. 3.1.0 resolves the executable from the bundle's Info.plist CFBundleExecutable (microsoft/vscode-test#348, #349), letting the tests track latest stable VS Code again without pinning.
With @vscode/test-electron 3.1.0 the macOS 1.131.0 bundle launches correctly, so advance the pinned test VS Code from 1.130.0 to the current stable 1.131.0.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the extension’s VS Code integration-test harness to restore macOS compatibility and keep CI deterministic by bumping @vscode/test-electron and advancing the pinned stable VS Code version used for scenario/E2E tests.
Changes:
- Bump
@vscode/test-electronfrom^2.3.10to^3.1.0. - Move the pinned test VS Code version from
1.130.0to1.131.0. - Update
yarn.lockto reflect the dependency bump (including the associated lockfile reordering/churn).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Extension/package.json | Updates the devDependency on @vscode/test-electron to ^3.1.0. |
| Extension/yarn.lock | Pins @vscode/test-electron to 3.1.0 in the lockfile and updates related entries. |
| Extension/.scripts/vscode.ts | Advances the pinned test VS Code version to 1.131.0 and updates the rationale comment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Colengms
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
@vscode/test-electron^2.3.10→^3.1.0and advances the pinned test VS Code from1.130.0to the current stable1.131.0.VS Code 1.110 renamed the macOS main binary from
Contents/MacOS/Electronto the product name and later removed the compatibility symlink (microsoft/vscode#326502), so@vscode/test-electron≤ 3.0.0 — which hardcodes theElectronname — fails to launch downloaded stable builds on macOS withspawn .../Contents/MacOS/Electron ENOENT. 3.1.0 resolves the executable from the bundle'sInfo.plistCFBundleExecutable(microsoft/vscode-test#348, #349), so macOS 1.110+ builds launch again.With 3.1.0 in place, the pin introduced in #14618 is moved forward to
1.131.0(kept pinned for deterministic CI rather than always pulling latest). The bump and the pin move go together — 1.131.0 only launches on macOS with 3.1.0.Lockfile churn is limited to the
test-electronentry (its 3.1.0 dependencies were already present). 3.1.0 remains CommonJS and preserves the APIs used here (downloadAndUnzipVSCode,runVSCodeCommand,resolveCliArgsFromVSCodeExecutablePath,runTests,VSCodeCommandError); it requires Node ≥ 22, which CI already uses (Node 24).