fix(openapi3): preserve envelopes for variants sharing a payload type - #11990
Draft
Timothee Guerin (timotheeguerin) wants to merge 1 commit into
Draft
Timothee Guerin (timotheeguerin) wants to merge 1 commit into
Timothee Guerin (timotheeguerin) wants to merge 1 commit into
Conversation
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 1.6.0, discriminated union variants with the same payload type reuse the first variant's envelope. This repeats its schema in
oneOfand points every discriminator mapping to it, rejecting valid variants.This now emits distinct
LimitDaily,LimitWeekly, andLimitMonthlyenvelopes with matching discriminator values. Envelope caching uses the variant name within its union, preserving visibility-specific reuse.Fixes the regression introduced by #8711.
Fixes #11979.