Skip to content

fix(website): give docs sidebar navigation a proper landmark box #11414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timotheeguerin wants to merge 2 commits into
base: main
Choose a base branch
from
+24 −0
Open

fix(website): give docs sidebar navigation a proper landmark box #11414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e3421f
fix(website): give docs sidebar navigation a proper landmark box
timotheeguerin Jul 27, 2026
7fafc11
chore: add WCAG to cspell word list
timotheeguerin Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cspell.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ words:
- Vsts
- vswhere
- wday
- WCAG
- weidxu
- westus
- WHATWG
Expand Down
23 changes: 23 additions & 0 deletions website/src/components/starlight-overrides/PageFrame.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,27 @@ import Footer from "../footer/footer.astro";
z-index: 100;
width: 100%;
}

/*
* Starlight wraps the docs sidebar in `<nav class="sidebar" aria-label>` but
* makes the inner `.sidebar-pane` `position: fixed`. On desktop that leaves
* the `<nav>` landmark element itself with an empty, collapsed layout box, so
* assistive tech / landmark tools report the visible left navigation as not
* belonging to any landmark region (#10793, WCAG 1.3.1). Move the fixed
* positioning onto the `<nav>` landmark itself so its bounding box coincides
* with the visible sidebar, and let the pane fill it.
*/
@media (min-width: 50rem) {
:global(nav.sidebar) {
position: fixed;
inset-block: var(--sl-nav-height) 0;
inset-inline-start: 0;
width: var(--sl-sidebar-width);
}
:global(nav.sidebar > .sidebar-pane) {
position: static;
width: 100%;
height: 100%;
}
}
</style>
Loading