Skip Non-Public Types from ModelReaderWriterContext

[jorgerangel-msft]

Internal types should not be included as part of the ModelReaderWriterBuildable attribute. This arose as part of this discussion Azure/azure-sdk-for-net#63385 (comment)

[github-actions]

🎯 Issue Triage

The C# client emitter includes non-public model types in ModelReaderWriterBuildable attributes on the generated ModelReaderWriterContext. Those inaccessible registrations should be omitted while public buildable models remain registered.

Category: Bug

Area: emitter:client:csharp

⚠️ No reproduction provided. A minimal repro would help diagnose this issue.

🔍 Analysis

This affects ModelReaderWriterContext generation in @typespec/http-client-csharp. The likely gap is that buildable-type collection or attribute emission does not consistently filter providers by effective C# accessibility before emitting ModelReaderWriterBuildable(typeof(...)).

No strong duplicate was found. #11845 is related to removing internal models referenced only through erased union metadata, and #11587 addressed obsolete last-contract registrations, but neither covers excluding all non-public context registrations. An implementation is already linked in #12047.

📝 Suggested next steps

• Add a focused generator test containing public and non-public buildable model types.
• Verify only public types are emitted as ModelReaderWriterBuildable attributes.
• Confirm [WIP] Skip non-public types from ModelReaderWriterContext #12047 preserves registrations required by generated serialization paths.

Generated by Agentic Triage