Python: Fix 18 broken links in ALL_SETTINGS.md after connector restructure - #14376
Open
陈志谦 (simpleqt) wants to merge 2 commits into
Open
Python: Fix 18 broken links in ALL_SETTINGS.md after connector restructure#14376陈志谦 (simpleqt) wants to merge 2 commits into
陈志谦 (simpleqt) wants to merge 2 commits into
Conversation
…cture Memory-store links pointed at connectors/memory/<provider>/ (classes now live under connectors/memory_stores/<provider>/), settings links pointed at per-provider settings modules that were consolidated into connectors/<provider>.py, AzureCosmosDBSettings was renamed to AzureCosmosDBforMongoDBSettings, and the Bing row referenced the removed python search_engine connector (drop it). All targets verified to exist via git ls-files.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The Azure Cosmos DB “Settings Class” link text references a settings class name that does not exist in the linked module, leaving a broken/misleading documentation reference.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Python sample documentation table in python/samples/concepts/setup/ALL_SETTINGS.md to reflect the post-restructure connector layout, primarily by fixing broken relative links to memory store implementations and consolidated settings modules.
Changes:
- Updated memory-store links from
connectors/memory/...toconnectors/memory_stores/...for several providers. - Updated “Settings Class” links to point at consolidated connector modules (and removed the obsolete Bing row).
File summaries
| File | Description |
|---|---|
| python/samples/concepts/setup/ALL_SETTINGS.md | Fixes/updates relative links in the settings reference table after the connector restructure. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| | Weaviate | [WeaviateMemoryService](../../../semantic_kernel/connectors/memory/weaviate/weaviate_memory_store.py) | url, <br> api_key, <br> use_embed | WEAVIATE_URL, <br> WEAVIATE_API_KEY, <br> WEAVIATE_USE_EMBED | No, <br> No, <br> No | [WeaviateSettings](../../../semantic_kernel/connectors/memory/weaviate/weaviate_settings.py) | | ||
| | AstraDB | [AstraDBMemoryService](../../../semantic_kernel/connectors/memory_stores/astradb/astradb_memory_store.py) | app_token, <br> db_id, <br> region, <br> keyspace | ASTRADB_APP_TOKEN, <br> ASTRADB_DB_ID, <br> ASTRADB_REGION, <br> ASTRADB_KEYSPACE | Yes, <br> Yes, <br> Yes, <br> Yes | [AstraDBSettings](../../../semantic_kernel/connectors/memory_stores/astradb/astradb_settings.py) | | ||
| | Azure AI Search | [AzureAISearchMemoryService](../../../semantic_kernel/connectors/memory_stores/azure_cognitive_search/azure_cognitive_search_memory_store.py) | api_key, <br> endpoint, <br> index_name | AZURE_AI_SEARCH_API_KEY, <br> AZURE_AI_SEARCH_ENDPOINT, <br> AZURE_AI_SEARCH_INDEX_NAME | No, <br> Yes, <br> No | [AzureAISearchSettings](../../../semantic_kernel/connectors/azure_ai_search.py) | | ||
| | Azure Cosmos DB | [AzureCosmosDBMemoryService](../../../semantic_kernel/connectors/memory_stores/azure_cosmosdb/azure_cosmos_db_memory_store.py) | api, <br> connection_string | AZURE_COSMOS_DB_API, <br> AZURE_COSMOS_DB_CONNECTION_STRING or AZCOSMOS_CONNSTR | No, <br> No | [AzureCosmosDBforMongoDBSettings](../../../semantic_kernel/connectors/azure_cosmos_db.py) | |
The prior label AzureCosmosDBforMongoDBSettings named a class that no longer exists in connectors/azure_cosmos_db.py (only CosmosMongoSettings and CosmosNoSqlSettings are defined there); use the Mongo settings class matching this memory store's MongoDB-backed connection string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 18 broken relative links in
python/samples/concepts/setup/ALL_SETTINGS.md(all verified againstgit ls-files; this file is excluded from linkspector, which is why CI never caught them):connectors/memory/<provider>/...→connectors/memory_stores/<provider>/...(AstraDB, Azure AI Search, Azure Cosmos DB, MongoDB Atlas, Pinecone, Postgres, Redis, Weaviate)AstraDBSettings→memory_stores/astradb/astradb_settings.py,AzureAISearchSettings→connectors/azure_ai_search.py,MongoDBAtlasSettings→connectors/mongodb.py,PineconeSettings→connectors/pinecone.py,PostgresSettings→connectors/postgres.py,RedisSettings→connectors/redis.py,WeaviateSettings→connectors/weaviate.pyAzureCosmosDBSettingsno longer exists; the store now usesAzureCosmosDBforMongoDBSettingsfromconnectors/azure_cosmos_db.py(as imported bymemory_stores/azure_cosmosdb/azure_cosmos_db_memory_store.py), relinked and relabeledsearch_engineconnector no longer exists in the repoContribution checklist: