Bump transformers from 5.5.0 to 5.10.1 in /python - #14358
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: Findings reported
Scope: full PR (1 commit(s)): ca8ef4673379
Model: claude-opus-4.8
Overview
This Dependabot change touches only python/uv.lock: it advances transformers across the 4→5 major boundary to 5.10.1 (piggy-backing a huggingface-hub 0.x→1.x bump) and simplifies redundant sys_platform environment markers. The marker churn was verified to be a semantic no-op because the resolution universe is pinned to exactly {darwin, linux, win32}, so dropping the three-way disjunction changes no install set. The one residual risk is real and confirmed by reproduction: transformers 5.x deleted the text2text-generation (the connector's default) and summarization pipeline tasks, so HuggingFaceTextCompletion now fails at construction for two of its three advertised tasks, and the mocked unit tests hide it.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
1 verified finding remained after source verification (1 high) across 1 file. Details are attached to the affected lines below.
Affected areas: python/uv.lock
| @@ -7391,29 +7381,28 @@ wheels = [ | |||
|
|
|||
| [[package]] | |||
| name = "transformers" | |||
| version = "4.57.6" | |||
| version = "5.10.1" | |||
There was a problem hiding this comment.
Bumping transformers to 5.10.1 crosses the 4→5 major boundary, which removed the text2text-generation and summarization pipeline tasks — in 5.10.1, transformers.pipelines.SUPPORTED_TASKS contains only text-generation of the three (verified against the pinned version). HuggingFaceTextCompletion defaults to task="text2text-generation" and calls pipeline(task=task, ...) at python/semantic_kernel/connectors/ai/hugging_face/services/hf_text_completion.py:72, so constructing the service with the default task — or with task="summarization" — now raises KeyError: "Unknown task ..." on the first call. Two of the connector's three advertised tasks are broken at construction. The existing unit tests patch pipeline, so CI stays green while the real connector fails. Please either cap the dependency at transformers[torch] >=4.28,<5.0 in python/pyproject.toml (keeping the lock on 4.57.6), or update the connector to map the removed seq2seq tasks onto a 5.x-supported task and add a non-mocked construction test before adopting 5.x.
Bumps [transformers](https://github.com/huggingface/transformers) from 5.5.0 to 5.10.1. - [Release notes](https://github.com/huggingface/transformers/releases) - [Commits](huggingface/transformers@v5.5.0...v5.10.1) --- updated-dependencies: - dependency-name: transformers dependency-version: 5.10.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
ca8ef46 to
ba2b1c7
Compare
Bumps transformers from 5.5.0 to 5.10.1.
Release notes
Sourced from transformers's releases.
... (truncated)
Commits
90c3ae5Patch because we had to yank 5.10 because the release branch was not up to date0bd94b3v5.10.01423d22who needs encoders? (#46385)50eb20aFix dsv4 dequant + tp/ep (#46378)74464e8Fix wrong changes produced by style/repo. check bot (#46371)1b8ec34Fix path traversal when saving Bark voice preset embeddings (#46237)e820678Add Sapiens2 Model (#45919)595721cPass library_name/version to Hub calls via a shared HfApi (#46318)0f0036cdocs: update ACL Anthology URL in CITATION.cff (#46352)fa6c830DeepGEMM BF16 + mixed FP8/FP4 + MegaMoE + refactor (#45634)