Skip to content

fix(portal): retain iteration comparison before value entry - #1540

Open
Naveen Chatlapalli (1aifanatic) wants to merge 1 commit into
microsoft:mainfrom
1aifanatic:fix/1171-iterations-filter-operator
Open

Naveen Chatlapalli (1aifanatic) wants to merge 1 commit into
microsoft:mainfrom
1aifanatic:fix/1171-iterations-filter-operator

Conversation

@1aifanatic

Copy link
Copy Markdown

Fixes #1171.

The Runs page used to delete the comparison operator whenever its numeric value was empty. Selecting ≤ or = before typing a number therefore appeared to do nothing. The Iterations filter now retains the chosen operator in URL state while the number is empty and sends it to the API only once a number is entered. Both Turns and Max iterations use the same behavior.

Added a Storybook interaction for choosing an operator before entering a number and documented the URL/API behavior.

Validation: pnpm --filter portal lint; 33 Storybook play tests via the Portal Vite config; git diff --check.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't change comparison method until I put a number in

1 participant