Repository navigation
feat: observation criteria with taxonomy and run/iteration subject (#1156) #1206
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -269,6 +269,66 @@ | |
|
|
||
| expect(res.status).toBe(400); | ||
| }); | ||
|
|
||
| it("creates an observation criterion with a taxonomy element", async () => { | ||
| (mocks.criteriaCollection.findOne as any).mockResolvedValue(null); | ||
|
|
||
| const res = await request(app) | ||
| .post("/api/v1/criteria") | ||
| .send({ | ||
| id: "obs_crit", | ||
| prompt: "Did the agent use current deps?", | ||
| dependsOn: [], | ||
| kind: "observation", | ||
| taxonomyElementId: "dimension:dependency-currency", | ||
| }); | ||
|
|
||
| expect(res.status).toBe(201); | ||
|
Check failure on line 286 in apps/api/src/endpoints.test.ts
|
||
| expect(res.body).toHaveProperty("kind", "observation"); | ||
| expect(res.body).toHaveProperty("taxonomyElementId", "dimension:dependency-currency"); | ||
| }); | ||
|
|
||
| it("rejects an unknown taxonomyElementId", async () => { | ||
| (mocks.criteriaCollection.findOne as any).mockResolvedValue(null); | ||
|
|
||
| const res = await request(app) | ||
| .post("/api/v1/criteria") | ||
| .send({ id: "bad_tax", prompt: "x", dependsOn: [], kind: "observation", taxonomyElementId: "dimension:nope" }); | ||
|
|
||
| expect(res.status).toBe(400); | ||
| }); | ||
|
|
||
| it("defaults an observation's subject to 'run'", async () => { | ||
| (mocks.criteriaCollection.findOne as any).mockResolvedValue(null); | ||
|
|
||
| const res = await request(app) | ||
| .post("/api/v1/criteria") | ||
| .send({ id: "obs_subj", prompt: "Did the agent add then remove a dep?", dependsOn: [], kind: "observation" }); | ||
|
|
||
| expect(res.status).toBe(201); | ||
|
Check failure on line 308 in apps/api/src/endpoints.test.ts
|
||
| expect(res.body).toHaveProperty("subject", "run"); | ||
| }); | ||
|
|
||
| it("creates an observation with an explicit subject:'iteration' override", async () => { | ||
| (mocks.criteriaCollection.findOne as any).mockResolvedValue(null); | ||
|
|
||
| const res = await request(app) | ||
| .post("/api/v1/criteria") | ||
| .send({ id: "obs_iter", prompt: "x", dependsOn: [], kind: "observation", subject: "iteration" }); | ||
|
|
||
| expect(res.status).toBe(201); | ||
|
Check failure on line 319 in apps/api/src/endpoints.test.ts
|
||
| expect(res.body).toHaveProperty("subject", "iteration"); | ||
| }); | ||
|
|
||
| it("rejects subject:'run' on a gate criterion", async () => { | ||
| (mocks.criteriaCollection.findOne as any).mockResolvedValue(null); | ||
|
|
||
| const res = await request(app) | ||
| .post("/api/v1/criteria") | ||
| .send({ id: "gate_run", prompt: "x", dependsOn: [], kind: "gate", subject: "run" }); | ||
|
|
||
| expect(res.status).toBe(400); | ||
| }); | ||
| }); | ||
|
|
||
| describe("POST /api/v1/criteria/seed", () => { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Supply projectId in the new observation endpoint tests
These new POSTs omit the required project query parameter. Consequently, the three happy-path tests return 400 instead of 201, and the new rejection tests return 400 for missing scope before they exercise taxonomy/subject validation. Running the endpoint suite produces three failures from these additions.
Please add
?projectId=${TEST_PROJECT_ID}to these requests and use the existingrequest(testServer())helper so the tests reach the intended behavior without creating extra servers.