fix(0.81, macos): shadow color and scroll indicator crashes, two compiler warnings

.nx/version-plans/version-plan-1792088305769.md

@@ -0,0 +1,5 @@
+---
+__default__: patch
+---
+
+Fix macOS crashes when setting a shadow color or scroll indicator insets, and two compiler warnings

nx.json

@@ -21,7 +21,7 @@
       "versionActionsOptions": {
         "currentVersionResolver": "registry",
         "currentVersionResolverMetadata": {
-          "tag": "latest"
+          "tag": "0.81-stable"
         }
       },
       "useLegacyVersioning": false

packages/react-native/Libraries/Network/RCTInspectorNetworkReporter.mm

@@ -126,7 +126,7 @@ + (void)reportResponseEnd:(NSNumber *)requestId encodedDataLength:(int)encodedDa
 #endif
 }
 
-+ (void)reportRequestFailed:(NSNumber *)requestId cancelled:(bool)cancelled
++ (void)reportRequestFailed:(NSNumber *)requestId cancelled:(BOOL)cancelled
 {
   NetworkReporter::getInstance().reportRequestFailed(requestId.stringValue.UTF8String, cancelled);
 

packages/react-native/React/Base/RCTUIKit.h

@@ -247,11 +247,8 @@ typedef NS_ENUM(NSInteger, UIViewContentMode) {
 };
 
 // UIInterface.h/NSUserInterfaceLayout.h
-enum : NSInteger
-{
-	UIUserInterfaceLayoutDirectionLeftToRight = NSUserInterfaceLayoutDirectionLeftToRight,
-	UIUserInterfaceLayoutDirectionRightToLeft = NSUserInterfaceLayoutDirectionRightToLeft,
-};
+#define UIUserInterfaceLayoutDirectionLeftToRight NSUserInterfaceLayoutDirectionLeftToRight
+#define UIUserInterfaceLayoutDirectionRightToLeft NSUserInterfaceLayoutDirectionRightToLeft
 
 // RCTActivityIndicatorView.h
 typedef NS_ENUM(NSInteger, UIActivityIndicatorViewStyle) {

packages/react-native/React/Views/RCTView.m

@@ -143,6 +143,7 @@ @implementation RCTView {
   NSTrackingArea *_trackingArea;
   BOOL _hasMouseOver;
   BOOL _mouseDownCanMoveWindow;
+  NSColor *_innerShadowColor;
 #endif // macOS]
   NSMutableDictionary<NSString *, NSDictionary *> *accessibilityActionsNameMap;
   NSMutableDictionary<NSString *, NSDictionary *> *accessibilityActionsLabelMap;
@@ -731,11 +732,8 @@ - (NSString *)description
 #if TARGET_OS_OSX // [macOS
 - (void)setShadowColor:(CGColorRef)shadowColor
 {
-    if (_shadowColor != shadowColor)
-    {
-        _shadowColor = shadowColor;
-        [self didUpdateShadow];
-    }
+  _innerShadowColor = shadowColor != NULL ? [NSColor colorWithCGColor:shadowColor] : nil;
+  [self didUpdateShadow];
 }
 
 - (void)setShadowOffset:(CGSize)shadowOffset
@@ -768,11 +766,7 @@ - (void)setShadowRadius:(CGFloat)shadowRadius
 -(void)didUpdateShadow
 {
     NSShadow *shadow = [NSShadow new];
-    NSColor *baseShadowColor = nil;
-    if (_shadowColor != NULL) {
-      baseShadowColor = [NSColor colorWithCGColor:_shadowColor];
-    }
-    shadow.shadowColor = [baseShadowColor colorWithAlphaComponent:[self shadowOpacity]];
+    shadow.shadowColor = [_innerShadowColor colorWithAlphaComponent:[self shadowOpacity]];
     shadow.shadowOffset = [self shadowOffset];
     shadow.shadowBlurRadius = [self shadowRadius];
     [self setShadow:shadow];

packages/react-native/React/Views/ScrollView/RCTScrollView.m

@@ -1505,6 +1505,18 @@ - (void)setContentInsetAdjustmentBehavior:(UIScrollViewContentInsetAdjustmentBeh
   _scrollView.contentInsetAdjustmentBehavior = behavior;
   _scrollView.contentOffset = contentOffset;
 }
+#else // [macOS] No-op setters, so setting these props from JS doesn't crash
+- (void)setScrollIndicatorInsets:(__unused UIEdgeInsets)value
+{
+}
+
+- (void)setVerticalScrollIndicatorInsets:(__unused UIEdgeInsets)value
+{
+}
+
+- (void)setAutomaticallyAdjustsScrollIndicatorInsets:(__unused BOOL)automaticallyAdjusts
+{
+}
 #endif // [macOS]
 #pragma clang diagnostic pop // [macOS]