Extend extension integration-tests for node environment#3136
Merged
joao-boechat merged 10 commits intomainfrom Apr 29, 2026
Merged
Extend extension integration-tests for node environment#3136joao-boechat merged 10 commits intomainfrom
joao-boechat merged 10 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the VS Code extension integration test infrastructure to run suites in both VS Code for the Web (Chromium) and VS Code Desktop (Electron), with separate bundling and entrypoints per environment.
Changes:
- Add separate Mocha runners and suite entrypoints for browser vs. Electron extension hosts.
- Update the test runner to execute each suite via
@vscode/test-weband (for non-empty suites)@vscode/test-electron. - Adjust CI pipelines to use
xvfb-runwhere needed and add the Electron test harness dependency.
Reviewed changes
Copilot reviewed 14 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| source/vscode/test/suites/runNode.ts | New Mocha runner for Electron extension host. |
| source/vscode/test/suites/runBrowser.ts | New Mocha runner for VS Code Web extension host. |
| source/vscode/test/suites/language-service/index.node.ts | New node/Electron entrypoint and local fake GitHub server for language-service suite. |
| source/vscode/test/suites/language-service/index.browser.ts | Switch to browser runner and configure fake GitHub endpoint for web runs. |
| source/vscode/test/suites/extensionUtils.ts | Add configurable GitHub endpoint used during test activation. |
| source/vscode/test/suites/empty/index.browser.ts | Add no-op “empty” suite for environment dry-run. |
| source/vscode/test/suites/debugger/qsharp.test.ts | Make debugger assertions/config paths compatible across web + node. |
| source/vscode/test/suites/debugger/openqasm.test.ts | Make debugger assertions/config paths compatible across web + node. |
| source/vscode/test/suites/debugger/index.node.ts | Switch node suite entrypoint to Electron runner. |
| source/vscode/test/suites/debugger/index.browser.ts | Add browser suite entrypoint for debugger tests. |
| source/vscode/test/runTests.mjs | Run suites in both web and Electron environments; update output paths. |
| source/vscode/test/buildTests.mjs | Build separate browser/node test bundles via esbuild. |
| package.json | Add @vscode/test-electron dependency. |
| package-lock.json | Lockfile updates for Electron test harness and transitive deps. |
| .gitignore | Ignore .vscode-test/ artifacts (Electron test downloads). |
| .github/workflows/multiplat.yml | Use xvfb-run for Linux integration tests. |
| .github/workflows/ci.yml | Wrap integration tests with xvfb-run on ubuntu CI job. |
| .ado/publish.yml | Update display name and run integration tests under xvfb-run. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
af8d1b3 to
72635ed
Compare
billti
reviewed
Apr 27, 2026
billti
approved these changes
Apr 27, 2026
minestarks
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Electron (Node.js) test execution to the VS Code integration test suites, which previously only ran in the browser via
@vscode/test-web. Tests now run in both environments to catch platform-specific issues.