Skip to content

test: enable setOffline test on chromium after roll - #42925

Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:test-fix-42174
Sep 25, 2026
Merged

Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:test-fix-42174

Conversation

@dgozman

@dgozman Dmitry Gozman (dgozman) commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #42174.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

5 flaky ⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:356 › screencast › should work for popups `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`

52285 passed, 1249 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/cli-drag.spec.ts:19 › drag between elements @mcp-windows-latest-firefox

8750 passed, 1480 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures here.

🟢 The only failure is a known flake — unrelated to this PR

mcp/cli-drag.spec.ts:19 on Windows Firefox has failed on plenty of other runs, including pushes to main.

Details

The PR only touches tests/library/browsercontext-basic.spec.ts, where it re-enables the setOffline test on Chromium. That doesn't touch MCP, the CLI, or drag-and-drop, and there are no failures in the library suites.

Pre-existing flake / infra

Triaged by the Playwright bot - agent run

@dgozman
Dmitry Gozman (dgozman) merged commit ef205eb into microsoft:main Sep 25, 2026
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chromium: page born into setOffline(true) context keeps navigator.onLine === true (1.62.0)

2 participants