feat(trace-viewer): show screencast frames during playback - #42751
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Hi, I'm the Playwright bot and I took a look at the CI failures here. 🟢 CI looks clear — the one failure is a known flake
DetailsOverall: 1 failed, 10 flaky across the two reports. Nothing points at this PR — the diff is confined to Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
467a8ea to
7290921
Compare
This comment has been minimized.
This comment has been minimized.
7290921 to
7e4567b
Compare
This comment has been minimized.
This comment has been minimized.
Playback and dragging the scrubber show the screencast at the current time. Stopping, releasing the scrubber, hovering an action or picking a locator snap back to the action snapshot. Traces with a video play the video itself, the thumbnails only index the film strip lanes.
7e4567b to
c7d2d66
Compare
Test results for "MCP"Warning The triggering workflow run ended with status 615 passed, 160 skipped Merge workflow run. |
Test results for "tests 1"Warning The triggering workflow run ended with status 1217 passed, 5 skipped Merge workflow run. |
| target={ariaModeTargets[snapshotTab]} | ||
| point={snapshotTab === 'action' ? action?.point : undefined} | ||
| box={snapshotTab === 'action' ? action?.box : undefined} | ||
| screencastFrame={screencastFrame} |
There was a problem hiding this comment.
what if video drifts away from the action and the image is different from the snapshot? may be confusing for the user that stopped on an action
Summary