fix(agents): add missing parentheses in test-generator example - #42744
Open
Metin Kılagöz (avgon) wants to merge 1 commit into
Open
Metin Kılagöz (avgon) wants to merge 1 commit into
Metin Kılagöz (avgon) wants to merge 1 commit into
Conversation
`async { page } =>` is a syntax error; the destructured parameter
needs parentheses: `async ({ page }) =>`.
This is the only concrete example of a generated spec in
playwright-test-generator.agent.md, so agents pattern-match
against it and reproduce the invalid syntax in their output.
Fixes microsoft#42743
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the invalid TypeScript syntax in the agent example that causes AI agents to reproduce the error in generated test output.
Change
async { page } =>->async ({ page }) =>inplaywright-test-generator.agent.mdThe destructured parameter needs parentheses. Without them, this is a syntax error that gets pattern-matched by agents and reproduced in every generated spec.
Fixes #42743