test: reach the trace viewer over IPv4 loopback under WSL - #42733
Merged
Yury Semikhatsky (yury-s) merged 1 commit intoSep 16, 2026
Merged
Yury Semikhatsky (yury-s) merged 1 commit into
Yury Semikhatsky (yury-s) merged 1 commit into
Conversation
Two tests load the trace viewer inside the browser under test rather than in the fixture's own Chromium page: "should notify parent when ready to receive messages" and "should render blob trace received from opener". On the webkit-wsl channel the browser runs in the WSL guest and reaches the host over mirrored networking, which mirrors the IPv4 loopback but not the host's ::1 -- and show-trace binds whatever localhost resolves to, which is ::1 on Windows. The viewer is unreachable from the guest, so both have timed out on every webkit-wsl run since microsoft#42451 added them. Pin the viewer to 127.0.0.1 for that channel, as playwright-client.spec.ts already does for browser.bind().
Contributor
Test results for "MCP"8564 passed, 1446 skipped Merge workflow run. |
Contributor
Test results for "tests 1"1 failed 4 flaky51723 passed, 1247 skipped Merge workflow run. |
Devin Rousso (dcrousso)
approved these changes
Sep 16, 2026
Yury Semikhatsky (yury-s)
approved these changes
Sep 16, 2026
Member
There was a problem hiding this comment.
There were a couple related reports, e.g. #41180 and a fix for vscode extension microsoft/playwright-vscode#769. We can probably resolve it by tweaking node ip resolution to prefer ipv4. This is fine to fix the tests but we need a solution for our users too.
Contributor
Author
|
Please merge since I don't think I have permissions. |
Yury Semikhatsky (yury-s)
merged commit Sep 16, 2026
6480b58
into
microsoft:main
44 of 45 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests load the trace viewer inside the browser under test rather than in the fixture's own Chromium page: "should notify parent when ready to receive messages" and "should render blob trace received from opener". On the webkit-wsl channel the browser runs in the WSL guest and reaches the host over mirrored networking, which mirrors the IPv4 loopback but not the host's ::1 -- and show-trace binds whatever localhost resolves to, which is ::1 on Windows. The viewer is unreachable from the guest, so both have timed out on every webkit-wsl run since #42451 added them.
Pin the viewer to 127.0.0.1 for that channel, as playwright-client.spec.ts already does for browser.bind().