Skip to content

fix: correct pending navigation log spacing#41949

Merged
Skn0tt merged 1 commit into
microsoft:mainfrom
Skn0tt:skn0tt-fix-navigation-log-spacing
Jul 23, 2026
Merged

fix: correct pending navigation log spacing#41949
Skn0tt merged 1 commit into
microsoft:mainfrom
Skn0tt:skn0tt-fix-navigation-log-spacing

Conversation

@Skn0tt

@Skn0tt Skn0tt commented Jul 23, 2026

Copy link
Copy Markdown
Member

This fixes a misplaced space in the pending-navigation call log, so it prints waiting for "http://..." instead of waiting for" http://...".

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c8568082-cd3f-4aa2-a7fa-15546d4738ff
@Skn0tt
Skn0tt requested a review from dgozman July 23, 2026 10:45
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/dashboard.spec.ts:108 › should activate session when show is called with -s @mcp-windows-latest-firefox

7785 passed, 1262 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

5 flaky ⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/har-websocket.spec.ts:231 › should embed websocket messages `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:371 › should produce network events, routing, and annotations for Service Worker `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-library] › library/video.spec.ts:664 › screencast › should capture full viewport `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-page] › page/page-goto.spec.ts:81 › should work with Cross-Origin-Opener-Policy `@firefox-ubuntu-22.04-node20`

50204 passed, 1190 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures here.

🟢 The one failure is a pre-existing flake — this PR is clear

The only red is [firefox] › mcp/dashboard.spec.ts:108 › should activate session when show is called with -s on mcp-windows-latest-firefox. That test has nothing to do with this diff (a one-character space fix in the pending-navigation call log in page.ts), and it flakes on unrelated commits.

Details

Overall: this PR touches one line — the waiting for "<url>" spacing in Page._setupNavigationLogging. It doesn't reach the MCP dashboard/session flow, Firefox, or Windows-specific code. No caused-by-PR failures.

Pre-existing flake / infra

  • [firefox] › mcp/dashboard.spec.ts:108 › should activate session when show is called with -s (mcp-windows-latest-firefox) — flake. Across the test-results DB this test finished failed in 3 of 976 runs (~0.3%), passing the other 973. The failures span commits this PR can't be responsible for:

    Same test, same lone Firefox-on-Windows bot each time — a classic low-rate flake, not a regression. Recent run history for the bot (oldest → newest, all-green except the three reds):

    🟩🟩🟩…🟩🟥🟩🟩🟥🟩🟩…🟩🟥🟩

Triaged by the Playwright bot - agent run

@Skn0tt
Skn0tt merged commit 2934858 into microsoft:main Jul 23, 2026
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants