perf(mcp): skip aria snapshot capture when the response discards it#41923
Open
m4ttheweric wants to merge 2 commits into
Open
perf(mcp): skip aria snapshot capture when the response discards it#41923m4ttheweric wants to merge 2 commits into
m4ttheweric wants to merge 2 commits into
Conversation
| // tree walk, which dominates response latency on heavy pages. Console, | ||
| // events and modal states are still reported. | ||
| if (!includeAria) { | ||
| if (this.modalStates().length) |
Member
There was a problem hiding this comment.
Duplication isn't nice here, easy to forget things in one of the modes.
Contributor
Author
There was a problem hiding this comment.
good call. collapsed the two paths so only the aria walk is conditional; the console/events tail and modal fallback now live in one place.
| }; | ||
| }); | ||
| } else if (this.modalStates().length) { | ||
| // Matches the aria path's modal fallback below, without the race: there |
Member
There was a problem hiding this comment.
We don't welcome low snr comments, coding agents are stubborn at not listening to our claude.md though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Response.serializecaptured a full aria snapshot on every tool response, then discarded it when the response does not render one (snapshot modenone, or tools likebrowser_run_code_unsafethat never request a snapshot).