Skip to content

feat(recorder): record actions by letting page events through naturally#41902

Open
dgozman wants to merge 1 commit into
microsoft:mainfrom
dgozman:recorder-passthrough-recording
Open

feat(recorder): record actions by letting page events through naturally#41902
dgozman wants to merge 1 commit into
microsoft:mainfrom
dgozman:recorder-passthrough-recording

Conversation

@dgozman

@dgozman dgozman commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • The default recorder no longer intercepts and re-performs user actions. Page events flow through naturally and actions are recorded from them, so the page reacts to real input while recording.
  • Right-click is still intercepted to open the actions dialog (Click / Right click / Double click / Hover / Pick locator); its items kick off the action and the resulting page events are recorded.
  • Click vs double click is decided in RecorderSignalProcessor by briefly buffering a single left click and merging a following double click into it; the api recorder now shares this path.

The default recorder no longer intercepts and re-performs user actions.
Events flow through to the page, and actions are recorded from them.
Right-click stays intercepted to open the actions dialog, whose items
kick off the action so the resulting page events are recorded naturally.

Click vs double click is disambiguated in the RecorderSignalProcessor by
briefly buffering a single left click and merging a following double
click into it; the api recorder now shares the same path.
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

7760 passed, 1249 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

7 flaky ⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:282 › should click `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:495 › screencast › should capture static page in persistent context @smoke `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:371 › should produce network events, routing, and annotations for Service Worker `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:185 › should watch new file `@ubuntu-latest-node22`

50009 passed, 1189 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants