Skip to content

FIX: fail the SQL Server readiness check when the container never starts #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Gaurav Sharma (bewithgaurav) wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

FIX: fail the SQL Server readiness check when the container never starts #722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 38 additions & 4 deletions eng/pipelines/pr-validation-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,15 +516,32 @@
-d $(sqlServerImage)

# Starting SQL Server container…
sql_ready=false
for i in {1..30}; do
docker exec sqlserver \
if docker exec sqlserver \
/opt/mssql-tools18/bin/sqlcmd \
-S localhost \
-U SA \
-P "$DB_PASSWORD" \
-C -Q "SELECT 1" && break
-C -Q "SELECT 1"; then
sql_ready=true
break
fi
sleep 2
done
if [ "$sql_ready" != true ]; then
# one last probe, in case it came up during the final sleep
docker exec sqlserver \
/opt/mssql-tools18/bin/sqlcmd \
-S localhost \
-U SA \
-P "$DB_PASSWORD" \
-C -Q "SELECT 1" || {
echo "SQL Server did not become ready after 30 attempts"
docker logs --tail 200 sqlserver || true
exit 1
}
fi
displayName: 'Pull & start SQL Server (Docker)'
env:
DB_PASSWORD: $(DB_PASSWORD)
Expand Down Expand Up @@ -2454,15 +2471,32 @@
-d mcr.microsoft.com/mssql/server:2022-latest

# Wait until SQL Server is ready
sql_ready=false
for i in {1..30}; do
docker exec sqlserver \
if docker exec sqlserver \
/opt/mssql-tools18/bin/sqlcmd \
-S localhost \
-U SA \
-P "$(DB_PASSWORD)" \
-C -Q "SELECT 1" && break
-C -Q "SELECT 1"; then
sql_ready=true
break
fi
sleep 2
done
if [ "$sql_ready" != true ]; then
# one last probe, in case it came up during the final sleep
docker exec sqlserver \
/opt/mssql-tools18/bin/sqlcmd \
-S localhost \
-U SA \
-P "$(DB_PASSWORD)" \
-C -Q "SELECT 1" || {
echo "SQL Server did not become ready after 30 attempts"
docker logs --tail 200 sqlserver || true
exit 1
}
fi
displayName: 'Start SQL Server container'
env:
DB_PASSWORD: $(DB_PASSWORD)
Expand Down
Loading