FIX: Support Arrow View types in bulk copy - #717
Draft
gargsaumya wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
Adds an end-to-end regression test for passing a Polars DataFrame with an Arrow
string_viewcolumn directly toCursor.bulkcopy_arrow. The test asserts the exported Arrow type and verifies values and NULLs round-trip through SQL Server without callingDataFrame.to_arrow().Adds Polars to the test requirements so the regression runs in CI instead of being skipped.
Depends on microsoft/mssql-rs#259 and publication of the fixed
mssql_py_core0.1.9 wheel. After publication, this branch must updateeng/versions/mssql-py-core.versionfrom 0.1.8 to 0.1.9 before it is ready to merge.Validation
TestBulkcopyArrowLive::test_polars_string_view_c_streampassedtests/test_024_bulkcopy_arrow.pygit diff --checkpassed