Skip to content

Remove first-party DevSkim banned C function findings - #1049

Merged
Stephen Griffin (stephenegriffin) merged 4 commits into
mainfrom
cleanup/devskim-banned-c
Oct 25, 2026
Merged

Stephen Griffin (stephenegriffin) merged 4 commits into
mainfrom
cleanup/devskim-banned-c

Conversation

@stephenegriffin

@stephenegriffin Stephen Griffin (stephenegriffin) commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Replace flagged wprintf calls with wprintf_s, including format-checking macros.
  • Rename the custom binary parser rewind method to rewindToStart to eliminate false positives.
  • No analyzer suppressions or workflow changes. Leave mapistub SDK-header cleanup separate.
  • Remove nine pre-existing live-MAPI integration tests from the native unit-test project. Replace them with six mocked stream/property tests using existing fake MAPI entry points; retain existing mocked error-path coverage.
  • Mocked tests verify our wrapper/stream logic, not Outlook codec correctness or real MSG persistence.

Validation

  • Debug_Unicode x64 and Win32 solution builds passed.
  • Full native suites: 482/482 passed on each architecture, zero failures or skips.
  • Actual CLI help output unchanged by CRT replacements.
  • DevSkim 1.0.100 DS154189: 485 to zero first-party findings. Seven findings remain in initialized mapistub SDK headers; no suppression added.
  • clang-format 17 and whitespace checks passed.
  • mapistub checked current at 8e4d4bffacab68dc34425a4cf5888e926b21d2c0.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Test Results

    8 files  ± 0      8 suites  ±0   59s ⏱️ +8s
  482 tests + 6    482 ✅ + 6  0 💤 ±0  0 ❌ ±0 
3 856 runs  +48  3 856 ✅ +48  0 💤 ±0  0 ❌ ±0 

Results for commit 9d743f2. ± Comparison against base commit e4fbdad.

@stephenegriffin
Stephen Griffin (stephenegriffin) merged commit 7d60d04 into main Oct 25, 2026
21 checks passed
@stephenegriffin
Stephen Griffin (stephenegriffin) deleted the cleanup/devskim-banned-c branch October 25, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants