Skip to content

Add displayed-row CSV export to the table export dialog - #1043

Merged
Stephen Griffin (stephenegriffin) merged 4 commits into
mainfrom
feature/372-displayed-view-csv
Oct 25, 2026
Merged

Stephen Griffin (stephenegriffin) merged 4 commits into
mainfrom
feature/372-displayed-view-csv

Conversation

@stephenegriffin

Copy link
Copy Markdown
Member

Summary

Fixes #372.

  • Keep one Table > Export table command and offer XML property dump (default) or loaded displayed rows as CSV.
  • Use table.xml, the .xml extension, and the XML file filter for the existing table XML writer, which already emits a matching UTF-16 declaration and BOM.
  • Export CSV snapshots of all currently loaded rows in visual row/column order, omitting zero-width columns and preserving displayed cell text rather than fetching additional provider rows.
  • Write UTF-8 BOM, quoted fields, doubled embedded quotes, and CRLF records. Preserve embedded line breaks, Unicode, whitespace, and formula-like values exactly.
  • Require an explicit spreadsheet-formula warning confirmation, defaulting to Cancel. Snapshot before warning/Save As dialogs so notifications cannot alter the captured export.
  • Use HRESULT/WC/EC error handling and report file write/flush/close failures.
  • Update MAPIStubLibrary to current main (8e4d4bf).

Validation

  • Debug_Unicode x64 and Win32 builds passed.
  • 40/40 targeted XML table-output and CSV tests passed on each architecture.
  • Tests exercise actual Windows list controls, visual sorting/column order, hidden columns, snapshot independence, long cell/header text, exact UTF-8 CSV bytes, invalid Unicode, multi-chunk file writes/readback, and filesystem failures.
  • Whitespace check passed; working tree clean.

The combined format chooser and modal cancellation paths are not covered by end-to-end UI automation.

Fixes #372. Offer XML property dump and exact displayed-row CSV through one export command, and use XML Save As defaults for table property dumps.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment thread core/utility/csv.cpp
@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Test Results

    8 files  ± 0      8 suites  ±0   1m 0s ⏱️ +3s
  494 tests +12    494 ✅ +12  0 💤 ±0  0 ❌ ±0 
3 952 runs  +96  3 952 ✅ +96  0 💤 ±0  0 ❌ ±0 

Results for commit 72558f3. ± Comparison against base commit 7d60d04.

♻️ This comment has been updated with latest results.

bwittgen
bwittgen previously approved these changes Oct 25, 2026
Preserve both CSV export and compressed RTF resource definitions.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bwittgen
bwittgen previously approved these changes Oct 25, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@stephenegriffin
Stephen Griffin (stephenegriffin) merged commit ab95c90 into main Oct 25, 2026
21 checks passed
@stephenegriffin
Stephen Griffin (stephenegriffin) deleted the feature/372-displayed-view-csv branch October 25, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow for CSV export of folder views

3 participants