Use shared memory for broker pipes#1052
Merged
Merged
Conversation
This was referenced Jul 19, 2026
wdcui
force-pushed
the
wdcui/ulitebox/broker-pipe-shared-protocol
branch
from
July 19, 2026 17:33
24d5337 to
e94d2f0
Compare
wdcui
force-pushed
the
wdcui/ulitebox/broker-pipe-shared-only
branch
2 times, most recently
from
July 19, 2026 18:08
a4005be to
b41d939
Compare
Base automatically changed from
wdcui/ulitebox/broker-pipe-shared-protocol
to
ulitebox
July 19, 2026 18:18
wdcui
force-pushed
the
wdcui/ulitebox/broker-pipe-shared-only
branch
2 times, most recently
from
July 21, 2026 16:51
c10f4ed to
b1cf754
Compare
Establish one sealed memfd after broker protocol negotiation and reuse it at offset zero for serialized pipe transfers. Remove per-pipe resource responses and bump the incompatible pipe wire schema to protocol version 2. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ac86dd2d-0280-4d7b-87a8-5654ad1503a6
Use one serve_connection API with an explicit post-negotiation association setup callback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ac86dd2d-0280-4d7b-87a8-5654ad1503a6
Use one negotiate API with an explicit post-handshake shared-memory setup callback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ac86dd2d-0280-4d7b-87a8-5654ad1503a6
Name the post-negotiation callback after its specific responsibility of sending shared memory. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ac86dd2d-0280-4d7b-87a8-5654ad1503a6
Name the local post-negotiation callback receive_shared_memory to mirror the host send callback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ac86dd2d-0280-4d7b-87a8-5654ad1503a6
Reserve TestSharedMemory for byte-staging tests and name inert association resources NoopSharedMemory. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ac86dd2d-0280-4d7b-87a8-5654ad1503a6
Use one request failure model across top-level, event, and pipe handlers while preserving recoverable responses and terminal shared-memory failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ac86dd2d-0280-4d7b-87a8-5654ad1503a6
Verify recoverable failures allow subsequent requests and shared-memory failures abort without sending a response, replacing implementation-coupled helper assertions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ac86dd2d-0280-4d7b-87a8-5654ad1503a6
Keep the single-use shared-memory staging logic directly in read_pipe and write_pipe. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ac86dd2d-0280-4d7b-87a8-5654ad1503a6
Cover setup ordering, skipped setup paths, callback errors, and invalid shared-memory sizes while removing redundant private request tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ac86dd2d-0280-4d7b-87a8-5654ad1503a6
Exercise partial transfer counts and request/response size limits while removing redundant fake handle-error coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ac86dd2d-0280-4d7b-87a8-5654ad1503a6
The shared-memory transport update does not require a broker protocol version bump. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ac86dd2d-0280-4d7b-87a8-5654ad1503a6
Use connect_with_setup_deadline directly from retry loops instead of wrapping an already-connected stream. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ac86dd2d-0280-4d7b-87a8-5654ad1503a6
Add a minimal pipe write/read round trip to the real broker-process integration test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ac86dd2d-0280-4d7b-87a8-5654ad1503a6
wdcui
force-pushed
the
wdcui/ulitebox/broker-pipe-shared-only
branch
from
July 21, 2026 20:26
a58de7a to
76209d9
Compare
wdcui
enabled auto-merge
July 21, 2026 20:26
|
🤖 SemverChecks 🤖 Click for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each broker connection establishes one sealed memfd after protocol negotiation and reuses it at offset zero for serialized pipe transfers. Pipe requests carry transfer lengths and responses carry byte counts; the host and local adapters stage data through shared memory while BrokerCore remains authoritative for pipe state.