[DRAFT] IDK_S PTA#1026
Draft
sangho2 wants to merge 2 commits into
Draft
Conversation
sangho2
force-pushed
the
sanghle/optee/idks_pta
branch
from
July 13, 2026 23:53
7850306 to
6955223
Compare
sangho2
force-pushed
the
sanghle/lvbs/idk
branch
from
July 14, 2026 00:01
6031f3c to
c172e8a
Compare
sangho2
force-pushed
the
sanghle/optee/idks_pta
branch
2 times, most recently
from
July 14, 2026 00:14
91e4c3a to
205a633
Compare
sangho2
force-pushed
the
sanghle/lvbs/idk
branch
from
July 14, 2026 00:34
054e1c6 to
420f007
Compare
sangho2
force-pushed
the
sanghle/optee/idks_pta
branch
4 times, most recently
from
July 14, 2026 20:01
e5a3e08 to
65a67fb
Compare
sangho2
force-pushed
the
sanghle/optee/idks_pta
branch
from
July 14, 2026 23:16
65a67fb to
d531256
Compare
sangho2
force-pushed
the
sanghle/lvbs/idk
branch
3 times, most recently
from
July 22, 2026 16:11
300e832 to
1cb91e6
Compare
sangho2
force-pushed
the
sanghle/optee/idks_pta
branch
from
July 22, 2026 19:53
d531256 to
02010a7
Compare
|
ℹ️ Note: This semver check was run against the 🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
sangho2
commented
Jul 22, 2026
Comment on lines
+146
to
+164
| fn build_endorsement_data( | ||
| ta_data: &[u8], | ||
| ta_uuid: &TeeUuid, | ||
| ta_svn: u32, | ||
| ta_digest: &TaDigest, | ||
| ) -> Option<Vec<u8>> { | ||
| // MAGIC || VERSION || TA_DATA || TA_UUID || TA_SVN || TA_DIGEST || DEBUG || ISOLATION_SOLUTION | ||
| let capacity = ta_data.len().checked_add(IDKS_ENDORSEMENT_METADATA_LEN)?; | ||
| let mut endorsement = Vec::with_capacity(capacity); | ||
| endorsement.extend_from_slice(IDKS_ENDORSEMENT_MAGIC); | ||
| endorsement.extend_from_slice(&IDKS_ENDORSEMENT_VERSION.to_le_bytes()); | ||
| endorsement.extend_from_slice(ta_data); | ||
| endorsement.extend_from_slice(&ta_uuid.to_le_bytes()); | ||
| endorsement.extend_from_slice(&ta_svn.to_le_bytes()); | ||
| endorsement.extend_from_slice(ta_digest); | ||
| endorsement.push(IDKS_DEBUG_FLAG); | ||
| endorsement.extend_from_slice(ISOLATION_SOLUTION); | ||
| Some(endorsement) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This function would be the most important one within this PR. Need to decide the data to include and the claim format. Don't prefer to use any specific format (e.g., C-struct, JSON, CBOR/COSE, ...) here because it heavily depends on what the verifier expects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the IDK_S PTA. It currently provides one method which endorses TA-provided data with IDK_S.