Skip to content

Fix/multipart stray linebreak #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vincent Biret (baywet) merged 2 commits into from
Aug 14, 2026
+26 −1
Merged

Fix/multipart stray linebreak #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
579e944
test(multipart): assert correct CRLF framing for string parts
GitGud44 Aug 13, 2026
bb6764a
fix(multipart): strip stray CRLF appended to string part values in Mu…
GitGud44 Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/abstractions/kiota_abstractions/multipart_body.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def serialize(self, writer: SerializationWriter) -> None:
if isinstance(part_value[1], Parsable):
self._write_parsable(writer, part_value)
elif isinstance(part_value[1], str):
writer.write_str_value("", part_value[1])
writer.write_bytes_value("", part_value[1].encode('utf-8'))
elif isinstance(part_value[1], bytes):
writer.write_bytes_value("", part_value[1])
elif isinstance(part_value[1], io.IOBase):
Expand Down
25 changes: 25 additions & 0 deletions packages/serialization/multipart/tests/unit/test_multipart_serialization_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,3 +89,28 @@ def test_write_object_value_with_filename(user_1, mock_request_adapter, mock_ser
content = serialization_writer.get_serialized_content()
content_string = content.decode('utf-8')
assert content_string == f'--{mock_multipart_body.boundary}'+'\r\nContent-Type: application/json\r\nContent-Disposition: form-data; name="test user"\r\n\r\n{"id": "eac79bd3-fd08-4abf-9df2-2565cf3a3845", "workDuration": "2:00:00", "birthDay": "2017-09-04", "startWorkTime": "00:00:00", "createdDateTime": "2022-01-27T12:59:45", "businessPhones": ["+1 412 555 0109"], "mobilePhone": null, "accountEnabled": false, "jobTitle": "Auditor", "manager": {"id": "eac79bd3-fd08-4abf-9df2-2565cf3a3845"}}\r\n'+f'--{mock_multipart_body.boundary}'+'\r\nContent-Type: application/octet-stream\r\nContent-Disposition: form-data; name="file"; filename="file.txt"\r\n\r\nHello world\r\n'+f'--{mock_multipart_body.boundary}--\r\n'

def test_write_object_value_with_string_part(mock_request_adapter, mock_serialization_writer_factory, mock_multipart_body):
mock_request_adapter.get_serialization_writer_factory = Mock(return_value=mock_serialization_writer_factory)
mock_multipart_body.request_adapter = mock_request_adapter
mock_multipart_body.add_or_replace_part("message", "text/plain", "Hello world")


serialization_writer = MultipartSerializationWriter()
serialization_writer.write_object_value("", mock_multipart_body, None)
content = serialization_writer.get_serialized_content()
content_string = content.decode('utf-8')
assert content_string == f'--{mock_multipart_body.boundary}'+'\r\nContent-Type: text/plain\r\nContent-Disposition: form-data; name="message"\r\n\r\nHello world\r\n'+f'--{mock_multipart_body.boundary}--\r\n'

def test_write_object_value_with_multiple_string_parts(mock_request_adapter, mock_serialization_writer_factory, mock_multipart_body):
mock_request_adapter.get_serialization_writer_factory = Mock(return_value=mock_serialization_writer_factory)
mock_multipart_body.request_adapter = mock_request_adapter
mock_multipart_body.add_or_replace_part("message1", "text/plain", "Hello world")
mock_multipart_body.add_or_replace_part("message2", "text/plain", "Goodbye world")


serialization_writer = MultipartSerializationWriter()
serialization_writer.write_object_value("", mock_multipart_body, None)
content = serialization_writer.get_serialized_content()
content_string = content.decode('utf-8')
assert content_string == f'--{mock_multipart_body.boundary}'+'\r\nContent-Type: text/plain\r\nContent-Disposition: form-data; name="message1"\r\n\r\nHello world\r\n'+f'--{mock_multipart_body.boundary}'+'\r\nContent-Type: text/plain\r\nContent-Disposition: form-data; name="message2"\r\n\r\nGoodbye world\r\n'+f'--{mock_multipart_body.boundary}--\r\n'