cmd/containerd-shim-runhcs-v1: prevent zombie shims by adding timeout to stdin read#2824
Open
HarshalPatel1972 wants to merge 1 commit into
Open
cmd/containerd-shim-runhcs-v1: prevent zombie shims by adding timeout to stdin read#2824HarshalPatel1972 wants to merge 1 commit into
HarshalPatel1972 wants to merge 1 commit into
Conversation
… to stdin read When the containerd daemon restarts or exits unexpectedly on Windows, the named pipe write handles may be inherited or fail to immediately broadcast an EOF. Because io.ReadAll does not natively respect context.Context, the runhcs shim blocks indefinitely waiting for data, leaking the process and blocking network ports. This introduces a background monitor with a 5-second timeout that explicitly closes os.Stdin if the read takes too long. This forcefully aborts the blocking I/O read, allowing the shim to detect the daemon disconnection and terminate gracefully. Signed-off-by: Harshal Patel <hp842484@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmd/containerd-shim-runhcs-v1: prevent zombie shims by adding timeout to stdin read
When the containerd daemon restarts or exits unexpectedly on Windows, the
named pipe write handles may be inherited or fail to immediately broadcast
an EOF. Because io.ReadAll does not natively respect context.Context,
the runhcs shim blocks indefinitely waiting for data, leaking the process
and blocking network ports.
This introduces a background monitor with a 5-second timeout that explicitly
closes os.Stdin if the read takes too long. This forcefully aborts the blocking
I/O read, allowing the shim to detect the daemon disconnection and
terminate gracefully.
Signed-off-by: Harshal Patel hp842484@gmail.com