Use VS SDK to create syso file from Manifest#2694
Open
helsaawy wants to merge 2 commits intomicrosoft:mainfrom
Open
Use VS SDK to create syso file from Manifest#2694helsaawy wants to merge 2 commits intomicrosoft:mainfrom
helsaawy wants to merge 2 commits intomicrosoft:mainfrom
Conversation
helsaawy
force-pushed
the
switch-manifest-syso
branch
from
e225139 to
1d689e0
Compare
msscotb
reviewed
Apr 20, 2026
helsaawy
force-pushed
the
switch-manifest-syso
branch
from
1d689e0 to
bcf7763
Compare
Switch from using `github.com/josephspurrier/goversioninfo/cmd/goversioninfo` and checked in `*.syso` binary files to using Windows SDK to generate resource object files with embedded manifest directly. Auto-generate manifest XML using common template instead of having redundant files throughout repo. Add *.syso to `.gitignore` to keep binaries from being tracked or checked in. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
force-pushed
the
switch-manifest-syso
branch
2 times, most recently
from
1f416c2 to
5532a26
Compare
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
force-pushed
the
switch-manifest-syso
branch
from
5532a26 to
f5eeb17
Compare
jterry75
reviewed
Apr 21, 2026
| # Processors architecture to target. | ||
| # Use all to generate for all supported architectures. | ||
| [ValidateSet('amd64', 'arm64', 'all')] | ||
| $Architecture = 'all', |
Contributor
There was a problem hiding this comment.
Is the build env arch specific though? Why all?
jterry75
reviewed
Apr 21, 2026
| <asmv3:application> | ||
| <!-- https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation --> | ||
| <asmv3:windowsSettings xmlns:ws2="http://schemas.microsoft.com/SMI/2016/WindowsSettings"> | ||
| <ws2:longPathAware>true</ws2:longPathAware> |
jterry75
reviewed
Apr 21, 2026
| package manifest | ||
|
|
||
| //go:generate go tool github.com/josephspurrier/goversioninfo/cmd/goversioninfo -platform-specific | ||
| //go:generate pwsh -Command "../../../scripts/New-ResourceObjectFile.ps1 -ErrorAction 'Stop' -Destination '.' -Name 'hcsshim-test' -UseVersionFile -Architecture 'all'" |
Contributor
There was a problem hiding this comment.
I dont what this is? Why is there a pkg/manifest? What does it do?
jterry75
reviewed
Apr 21, 2026
| *.dylib | ||
|
|
||
| # generated | ||
| *.syso |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from using
github.com/josephspurrier/goversioninfo/cmd/goversioninfoand checked in*.sysobinary files to usingmt.exeto embed manifest files into the final binary.Generate resource COFF Object file from syso file.