Repository navigation
feat(react-datepicker-preview): scaffold package and DatePicker component - #36914
Merged
Merged
Conversation
…icker <!-- Thank you for submitting a pull request! Please verify that: * [ ] Code is up-to-date with the `master` branch * [ ] Your changes are covered by tests (if possible) * [ ] You've run `yarn change` locally PR flow tips: * [ ] Try to start with a Draft PR * [ ] Once you're ready (ideally the pipeline is passing) promote your PR to Ready for Review. This step will auto-assign reviewers for your PR. --> ## Previous Behavior <!-- This is the behavior we have today --> DatePicker Compat provides the existing date-input experience. There is no non-compat DatePicker preview package on this branch's base. ## New Behavior <!-- This is the behavior we should expect with the changes in this PR --> Adds the private DatePicker preview library and stories scaffold, workspace registration, and ownership entries. Defines the proposed non-compat DatePicker API and implementation requirements: compat visual/behavioral parity, Calendar Preview composition, v9 slots and event/data callbacks, validation, focus/accessibility, and a compat migration walkthrough. The scaffold is not a working DatePicker and does not implement the proposed API. ### Planned stack 1. This PR: current scaffold, workspace wiring, spec, and migration guide. 2. Dependent PR: styled DatePicker implementation, shared base hooks suitable for headless reuse, tests, and stories. 3. Dependent PR: headless DatePicker using the base hooks from layer 2, with its integration, tests, and stories. Layers 2 and 3 are deferred pending resolution of the component-package dependency prerequisite documented in the spec. No new DatePicker-to-Calendar/Input component dependency is introduced here. ### Validation - `yarn nx run-many -p react-datepicker-preview react-datepicker-preview-stories -t test lint type-check --parallel=3` — passed, including library/story lint and type checks, scaffold tests (20 tests and one snapshot), and dependency builds. - `git diff --cached --check` — passed before committing. - Runtime parity, browser interaction, visual regression, and screen-reader validation — not run; the component is still a scaffold. - Beachball change file — not added: the new library and stories packages are private and this layer changes no published package. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> - Fixes # — no linked issue provided. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Oct 18, 2026
Dmytro Kirpa (dmytrokirpa)
added this pull request to stack #36921
October 18, 2026 07:57
Co-authored-by: dmytrokirpa <1492102+dmytrokirpa@users.noreply.github.com>
Dmytro Kirpa (dmytrokirpa)
changed the title
Dmytro Kirpa (dmytrokirpa)
marked this pull request as ready for review
October 19, 2026 12:37
Paul Mardling (PaulGMardling)
approved these changes
Oct 19, 2026
Paul Mardling (PaulGMardling)
left a comment
Paul Mardling (PaulGMardling)
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Everything’s wired up for the private scaffold, with the actual implementation and validation coming in the follow-up PRs.
Dmytro Kirpa (dmytrokirpa)
requested review from
Martin Hochel (Hotell) and
Victor Genaev (mainframev)
October 19, 2026 14:09
Contributor
Author
|
Copilot resolve conflicts |
# Conflicts: # .github/CODEOWNERS # tsconfig.base.all.json Co-authored-by: dmytrokirpa <1492102+dmytrokirpa@users.noreply.github.com>
Contributor
Merged |
Contributor
Author
|
Copilot run the |
Contributor
Ran |
Martin Hochel (Hotell)
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
DatePicker Compat provides the existing date-input experience. There is no non-compat DatePicker preview package on this branch's base.
New Behavior
Adds the private DatePicker preview library and stories scaffold, workspace registration, and ownership entries.
Defines the proposed non-compat DatePicker API and implementation requirements: compat visual/behavioral parity, Calendar Preview composition, v9 slots and event/data callbacks, validation, focus/accessibility, and a compat migration walkthrough.
The scaffold is not a working DatePicker and does not implement the proposed API.
DatePicker stack
Independent prerequisite: #36917 contains the Calendar popup focus/geometry fixes and intentionally is not part of this GitHub PR stack. Merge it first, then rebase the DatePicker stack. Implementation and publication remain blocked drafts until that prerequisite is incorporated.
No new DatePicker-to-Calendar/Input component dependency is introduced by this scaffold PR; composition is implemented in the separate implementation layer. The earlier composition-prerequisite wording in this PR description is superseded by the current stack structure above.
Validation
yarn nx run-many -p react-datepicker-preview react-datepicker-preview-stories -t test lint type-check --parallel=3— passed, including library/story lint and type checks, scaffold tests (20 tests and one snapshot), and dependency builds.git diff --cached --check— passed before committing.Related Issue(s)
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com