fix(react-headless-components-preview): use tab navigation in Nav instead of arrow keys - #36609
Open
Dmytro Kirpa (dmytrokirpa) wants to merge 2 commits into
Open
fix(react-headless-components-preview): use tab navigation in Nav instead of arrow keys#36609Dmytro Kirpa (dmytrokirpa) wants to merge 2 commits into
Dmytro Kirpa (dmytrokirpa) wants to merge 2 commits into
Conversation
…tead of arrow keys
|
Pull request demo site: URL |
…ole on Nav and NavDrawerBody
📊 Bundle size report
Unchanged fixtures
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Removes the
focusgrouparrow-key navigation fromNavandNavDrawerBodyin the headless preview package. Navigation items are now reachable with sequentialTabnavigation.useNavno longer setsfocusgroup="toolbar block wrap"; it still setsrole="navigation".useNavDrawerBodyno longer setsfocusgroup; it still setsrole="navigation".Navfrom the focusgroup browser-support notice in the stories.Nav links are natively focusable, so tab navigation matches the expected behavior of a list of links and removes the dependency on the focusgroup polyfill for this component. The
navigationlandmark role is preserved on both surfaces.Verification
yarn nx run react-headless-components-preview:test -t Navpasses.