fix: correct headless component subpath exports - #36606
Open
Dmytro Kirpa (dmytrokirpa) wants to merge 2 commits into
Open
fix: correct headless component subpath exports#36606Dmytro Kirpa (dmytrokirpa) wants to merge 2 commits into
Dmytro Kirpa (dmytrokirpa) wants to merge 2 commits into
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
… entry The export-map-entry-exists extra test declared zero parameters, so react-conformance silently skipped it when disableTypeTests is enabled. Give it the options parameter, update the expected shape to the dual import/require conditional exports, disable it for subcomponents, and fix the stale ./tag-picker entry it caught.
Dmytro Kirpa (dmytrokirpa)
force-pushed
the
fix/headless-subpath-exports
branch
from
August 23, 2026 09:05
af9a7ea to
d8262b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
avatar-group,overflow,menu-button, andtag-pickersubpath exports to use the package's nestedimportandrequireconditions.cjsand.d.ctsfilesexport-map-entry-existsconformance test so it actually runs — it declared zero parameters, andreact-conformanceskips extra tests whose arity is not 1 whendisableTypeTestsis enabledimport/requireconditions, and disable it for subcomponents (they have no top-level entry file, so no export map entry of their own)@fluentui/react-headless-components-previewValidation
yarn nx run react-headless-components-preview:buildyarn nx run react-headless-components-preview:lintyarn nx test react-headless-components-preview --skip-nx-cache— 77 suites / 1030 tests passing, including the now-executing export map conformance testgit diff --check