docs(docsite-v9): clarify brand-background demo in ColorAndAppearance story - #36570
Open
Martin Hochel (Hotell) with Copilot wants to merge 2 commits into
Open
docs(docsite-v9): clarify brand-background demo in ColorAndAppearance story#36570Martin Hochel (Hotell) with Copilot wants to merge 2 commits into
Martin Hochel (Hotell) with Copilot wants to merge 2 commits into
Conversation
…e story Co-authored-by: Hotell <1223799+Hotell@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update badge story to improve visual distinction of brand wrapper
docs(react-badge): clarify brand-background demo in ColorAndAppearance story
Aug 13, 2026
Contributor
Martin Hochel (Hotell)
marked this pull request as ready for review
August 14, 2026 08:07
Martin Hochel (Hotell)
requested review from
a team and
Dmytro Kirpa (dmytrokirpa)
as code owners
August 14, 2026 08:07
Martin Hochel (Hotell)
approved these changes
Aug 14, 2026
Martin Hochel (Hotell)
enabled auto-merge (squash)
August 14, 2026 08:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The
ColorAndAppearancestory wrapssubtlebadges in a brand-colored<div>when appearance isghostoroutline, since those combinations are only intended for branded surfaces. The wrapper was a thin padded sliver with no explanation, so it read as a rendering artifact rather than deliberate demo context — particularly alongside the overflow behavior reported in #36556.Changes
colorNeutralForegroundOnBrandand base typography tokens.borderRadiusMedium,spacingVerticalS/spacingHorizontalMpadding, centered alignment and a gap between label and badge.BadgeWrappercomponent — it was re-created on every render (remounting its subtree each time); replaced with a direct conditional branch plus a comment explaining why the branch exists.Scope
Story-only. This does not address the missing
fui-Badgeclass onghost-subtle/outline-subtlebadges from #36556 — that lives in the Badge styles hook and needs a separate fix. No change file:@fluentui/react-badge-storiesis private andbeachball checkreports none needed.