Skip to content

[Shimmer] Introduce ShimmerLineConfiguration to enable more control over ShimmerLineView - #2282

Open
Des Marks (nodes11) wants to merge 4 commits into
microsoft:mainfrom
nodes11:shimmer_line_config_updated
Open

Des Marks (nodes11) wants to merge 4 commits into
microsoft:mainfrom
nodes11:shimmer_line_config_updated

Conversation

@nodes11

@nodes11 Des Marks (nodes11) commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

The existing ShimmerLinesView implementation does not allow for a Shimmer view that has lines with varying widths and heights. To enable this, I have created a ShimmerLineConfiguration class that defines the characteristics of a line and updated the ShimmerLinesView to take an optional array of ShimmerLineConfiguration objects that make up the shimmer view.

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

Validated in demo controller. Validated in internal use case.

Visual Verification
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-08-04.at.13.46.34.mov

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@nodes11
Des Marks (nodes11) marked this pull request as ready for review August 4, 2026 20:51
@nodes11
Des Marks (nodes11) requested a review from a team as a code owner August 4, 2026 20:51
@nodes11
Des Marks (nodes11) force-pushed the shimmer_line_config_updated branch from 3cd9de4 to 39e9830 Compare August 11, 2026 22:07
@nodes11
Des Marks (nodes11) force-pushed the shimmer_line_config_updated branch from 39e9830 to f17bc68 Compare September 30, 2026 20:20

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant