Repository navigation
[Shimmer] Introduce ShimmerLineConfiguration to enable more control over ShimmerLineView - #2282
Open
Des Marks (nodes11) wants to merge 4 commits into
Open
Des Marks (nodes11) wants to merge 4 commits into
Des Marks (nodes11) wants to merge 4 commits into
Conversation
Des Marks (nodes11)
marked this pull request as ready for review
August 4, 2026 20:51
Des Marks (nodes11)
force-pushed
the
shimmer_line_config_updated
branch
from
August 11, 2026 22:07
3cd9de4 to
39e9830
Compare
Des Marks (nodes11)
force-pushed
the
shimmer_line_config_updated
branch
from
September 30, 2026 20:20
39e9830 to
f17bc68
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
The existing
ShimmerLinesViewimplementation does not allow for a Shimmer view that has lines with varying widths and heights. To enable this, I have created aShimmerLineConfigurationclass that defines the characteristics of a line and updated theShimmerLinesViewto take an optional array ofShimmerLineConfigurationobjects that make up the shimmer view.Binary change
(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)
Verification
Validated in demo controller. Validated in internal use case.
Visual Verification
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-08-04.at.13.46.34.mov
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow