Sanitize all text before printing - #913
Merged
Merged
Conversation
| use stdext::arena::{self, Arena, scratch_arena}; | ||
| use stdext::arena_format; | ||
| use stdext::collections::{BString, BVec}; | ||
| use stdext::unicode::sanitize_control_chars; |
Member
Author
There was a problem hiding this comment.
Notes:
- There are new helpers on
BString/BVecto make generics possible (e.g.write!()into aBVec; stdlib has them too). You can mostly ignore those changes. - There's now 1 central function to sanitize strings. It's in sanitize.rs at the end and I suggest reading it first.
- With the sanitizer in place, all of the TextBuffer rendering logic moved into Framebuffer.
Leonard Hecker (lhecker)
added
C-bug
Dustin L. Howett (DHowett)
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On UNIX it's possible to create filenames containing arbitrary escape
sequences. To avoid injecting them into stdout, this sanitizes all
output written to the
Framebuffer.