ci: make lockfile and render checks blocking#16993
Merged
christopherco merged 4 commits intomicrosoft:tomls/base/mainfrom May 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens CI enforcement around generated artifacts by making rendered-spec drift and lockfile drift checks blocking, and by removing the previous “timestamp-only noise” exception so azldev component render output must be deterministic.
Changes:
- Remove
continue-on-errorfrom the render + locks update steps and add an explicit “Fail on lock drift” gate. - Remove the “disregard this comment” warning banners from both drift PR comment formatters.
- Remove changelog date regex normalization from the rendered-spec drift checker (treat all diffs as real).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/scripts/render-specs-check/post_render_comment.py | Updates remediation command selection logic and removes the temporary warning banner from the PR comment. |
| .github/workflows/scripts/render-specs-check/check_rendered_specs.py | Removes timestamp/date normalization and simplifies drift detection + remediation messaging. |
| .github/workflows/scripts/locks-check/post_locks_comment.py | Removes the temporary warning banner from the locks drift PR comment. |
| .github/workflows/check-rendered-specs.yml | Makes render/lock drift checks blocking; ensures render patch artifacts upload even on failure; adds a lock drift failure step. |
alzdev render should also be deterministic so drop regex filtering.
4c58dc8 to
9152145
Compare
christopherco
approved these changes
May 2, 2026
Collaborator
christopherco
left a comment
There was a problem hiding this comment.
Generally LGTM. Provided some non-blocking feedback offline to evaluate whether we want to pursue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alzdev comp rendershould also be deterministic so drop regex filtering for dates as well.