Skip to content

ci: make lockfile and render checks blocking#16993

Merged
christopherco merged 4 commits intomicrosoft:tomls/base/mainfrom
dmcilvaney:damcilva/4.0/enable_update_render_ci_gates
May 2, 2026
Merged

ci: make lockfile and render checks blocking#16993
christopherco merged 4 commits intomicrosoft:tomls/base/mainfrom
dmcilvaney:damcilva/4.0/enable_update_render_ci_gates

Conversation

@dmcilvaney
Copy link
Copy Markdown
Contributor

alzdev comp render should also be deterministic so drop regex filtering for dates as well.

Copilot AI review requested due to automatic review settings May 1, 2026 23:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens CI enforcement around generated artifacts by making rendered-spec drift and lockfile drift checks blocking, and by removing the previous “timestamp-only noise” exception so azldev component render output must be deterministic.

Changes:

  • Remove continue-on-error from the render + locks update steps and add an explicit “Fail on lock drift” gate.
  • Remove the “disregard this comment” warning banners from both drift PR comment formatters.
  • Remove changelog date regex normalization from the rendered-spec drift checker (treat all diffs as real).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/scripts/render-specs-check/post_render_comment.py Updates remediation command selection logic and removes the temporary warning banner from the PR comment.
.github/workflows/scripts/render-specs-check/check_rendered_specs.py Removes timestamp/date normalization and simplifies drift detection + remediation messaging.
.github/workflows/scripts/locks-check/post_locks_comment.py Removes the temporary warning banner from the locks drift PR comment.
.github/workflows/check-rendered-specs.yml Makes render/lock drift checks blocking; ensures render patch artifacts upload even on failure; adds a lock drift failure step.

Comment thread .github/workflows/scripts/render-specs-check/post_render_comment.py
Comment thread .github/workflows/scripts/render-specs-check/check_rendered_specs.py Outdated
@dmcilvaney dmcilvaney force-pushed the damcilva/4.0/enable_update_render_ci_gates branch from 4c58dc8 to 9152145 Compare May 1, 2026 23:54
Copy link
Copy Markdown
Collaborator

@christopherco christopherco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. Provided some non-blocking feedback offline to evaluate whether we want to pursue.

@christopherco christopherco merged commit e5bbb3c into microsoft:tomls/base/main May 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants