fix(marketplace): resolve version tags from package remote - #3044
Open
Chandan Kumar (modelpath-dev) wants to merge 2 commits into
Open
Chandan Kumar (modelpath-dev) wants to merge 2 commits into
Chandan Kumar (modelpath-dev) wants to merge 2 commits into
Conversation
Version constraints listed tags on the marketplace catalog even when the plugin lives in a different package repo. Query the package remote so tag/version install works when those remotes differ.
Copilot started reviewing on behalf of
Chandan Kumar (modelpath-dev)
September 20, 2026 15:21
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Repository host parsing and SSH transport issues remain unresolved; two minor test improvements are also noted.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates marketplace version resolution to query tags from the package repository when sources differ from the marketplace catalog.
Changes:
- Forwards optional remote URLs during version and builder resolution.
- Resolves package coordinates from external marketplace sources.
- Adds unit coverage for remote lookup behavior.
| File | Summary |
|---|---|
tests/unit/marketplace/test_version_resolver.py |
Tests remote forwarding and diagnostics; nit (1 vote): parse diagnostic URLs instead of using substring matching. |
tests/unit/marketplace/test_marketplace_source_base.py |
Updates resolver test doubles. |
tests/unit/marketplace/test_marketplace_resolver.py |
Tests package-remote resolution. |
tests/unit/marketplace/test_builder.py |
Updates builder test doubles. |
src/apm_cli/marketplace/version_resolver.py |
Forwards optional remote URLs to reference resolution. |
src/apm_cli/marketplace/resolver.py |
Selects package remotes; critical (3 votes): preserve bare and host-qualified source semantics; moderate (1 vote): preserve SSH transport. |
src/apm_cli/marketplace/builder.py |
Uses source URLs for tag lookup; nit (1 vote): assert the forwarded source_url in builder tests. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Bare type:github locators and host-qualified repo fields must parse through DependencyReference so tags are listed on github.com, not the marketplace catalog host.
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2928
Why
Version constraints for marketplace installs listed git tags on the marketplace catalog even when the plugin lives in a separate package repository. Tags published only on the package remote never matched, so installs like
apm install pkg@marketplace#1.0.1failed withNo tag matching version. Query the package remote when the plugin source points there, and keep the catalog remote for in-marketplace packages.Scope
resolve_version_constraint: optionalremote_urlpassed through tolist_remote_refsresolve_marketplace_plugin: pick package coordinates fromdep_refor github/gitlab/git-subdir locators before falling back to the marketplaceMarketplaceBuilder: passsource_urlasremote_urlwhen listing refsremote_urlforwardingTradeoffs
Left in-marketplace / relative sources on the catalog remote. That is still where those packages publish tags.
Blast Radius
Touches marketplace install validation and builder tag resolution only. Auth for the lookup follows the package host when it differs from the catalog.
Verification
173 passed.