Python: preserve native keys in filtered vector delete tools - #8535
Open
Sunhy (Shy7777) wants to merge 1 commit into
Open
Sunhy (Shy7777) wants to merge 1 commit into
Sunhy (Shy7777) wants to merge 1 commit into
Conversation
Sunhy (Shy7777)
had a problem deploying
to
github-app-auth
September 18, 2026 16:50 — with
GitHub Actions
Error
Sunhy (Shy7777)
marked this pull request as ready for review
September 18, 2026 16:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
A filtered delete tool fails on MongoDB collections with
ObjectIdkeys, even though deleting the same key without a filter works. The filtered path converts retrieved keys to JSON strings and passes them straight to the connector, which expects native keys.Description & Review Guide
key_from_jsonhook before deletion. Add a MongoDB regression covering a matching subset, a mapped tenant field, and an empty match.processed_keysremains JSON-compatible. Public APIs, approval settings, and filtering behavior are unchanged. The matching regression fails on the base revision; the fix passes 113 MongoDB unit tests and 385 core vector/in-memory tests. Changed-file lint, formatting, and source type checking also pass. Live database integration tests were not run.Related Issue
Fixes #8534
No other open PR was found for this issue.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.