test: add unit tests for parse_json_output#32
Open
nuthalapativarun wants to merge 1 commit into
Open
Conversation
parse_json_output is called on every agent step but had no tests. Cover the done-demotion logic, non-dict JSON, malformed JSON, and the custom action_field parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
parse_json_outputinbase.pyis called on every agent step but has no test coverage. Thedone-demotion logic (demotingdone=truetofalsewhen there is a non-empty action) is a subtle invariant that is easy to break silently.Fix
Add
tests/unit/test_parse_json_output.pywith tests covering: valid JSON roundtrip,donedemotion when action is non-empty,donepreserved when action is empty, non-dict JSON raisesValueError, malformed JSON raisesValueError, and customaction_field.Changes
tests/unit/test_parse_json_output.py— new test file, 6 test casesNot affected
parse_json_outputimplementation — not changed