Update URL & Request & XMLHttpRequest interface to accept Location

[Adam Naji (Bashamega)]

closes #2536

Also, I couldn't figure out how to override fetch

[github-actions]

Thanks for the PR!

This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged.

[Adam Naji (Bashamega)]

Should i handle the fallback to WorkerLocation in the emitter or what should i do in this situation?

[Adam Naji (Bashamega)]

Updated

[半岛的蒟蒻bddjr (bddjr)]

🤔It seems that we need to separately make webworker.generated.d.ts exempt from this change.
I don't know how to do that, so I didn't submit a PR.

[Kagami Sascha Rosylight (saschanaz)]

Why not additionalTypes? 🤔

[Adam Naji (Bashamega)]

Because location is not supported in web worker, i don't know how to handle web worker

[Kagami Sascha Rosylight (saschanaz)]

the exposure checker should autoremove them... but maybe we don't do that for additionalTypes? 🤔

[Adam Naji (Bashamega)]

It wasn't implemented, but I have added it Kagami Sascha Rosylight (@saschanaz)

[Victor Turansky (turansky)]

Also, I couldn't figure out how to override fetch

Adam Naji (@Bashamega) should it also affect Request in that case?

[半岛的蒟蒻bddjr (bddjr)]

should it also affect Request in that case?

yes

new Request(location)

[Adam Naji (Bashamega)]

I have updated it. What do you think Kagami Sascha Rosylight (@saschanaz)

[半岛的蒟蒻bddjr (bddjr)]

ChatGPT suggested adding the type for fetch(location) like this:

 inputfiles/overridingTypes.jsonc

 "WindowOrWorkerGlobalScope": {
     "methods": {
         "method": {
+            "fetch": {
+                "signature": {
+                    "0": {
+                        "param": [
+                            {
+                                "name": "input",
+                                "additionalTypes": ["Location"]
+                            }
+                        ]
+                    }
+                }
+            },
             ...

[Adam Naji (Bashamega)]

Thanks for the help 半岛的蒟蒻bddjr (@bddjr) ... Updated

[半岛的蒟蒻bddjr (bddjr)]

Review by Gemini 3.8 Flash:

Thanks for working on this! A few findings during the review:

1. Typo in inputfiles/patches/fetch.kdl

In inputfiles/patches/fetch.kdl:

interface Request {
  constructor signatureIndex=0 {
    param input {
      additionalTypes input Location
    }
  }
}

input was accidentally included as a type in additionalTypes. It should be:

      additionalTypes Location

(It was silently stripped only because isKnownType("input") is false).

2. filterAdditionalTypes in src/build/expose.ts didn't actually affect parameters

In filterUnknownTypeFromSignature, param.push({ ...p, type: flattenType(filtered) }) spreads p rather than using the filtered additionalTypes from filtered[0]. In addition, deepClone returns early at method signatures and does not recurse into param directly.
As a result, additionalTypes on parameters remained unfiltered until isKnownType in emitter.ts.
To properly filter additionalTypes in expose.ts:

const additionalTypes = filterAdditionalTypes(p.additionalTypes, unexposedTypes);
param.push({
  ...p,
  type: flattenType(filtered),
  additionalTypes: additionalTypes?.length ? additionalTypes : undefined,
});

3. Supporting WorkerLocation in Web Workers

Regarding your question about WorkerLocation:

Should i handle the fallback to WorkerLocation in the emitter or what should i do in this situation?

Once expose.ts properly filters additionalTypes, we can simply specify:

additionalTypes Location WorkerLocation

• For DOM lib: WorkerLocation is unexposed and filtered out $\rightarrow$ results in Location.
• For Worker lib: Location is unexposed and filtered out $\rightarrow$ results in WorkerLocation.
  This allows workers to naturally accept location without any special fallback in emitter.ts!

[半岛的蒟蒻bddjr (bddjr)]

Review by Gemini 3.8 Flash:

Nice work on adding WorkerLocation! The generated baselines look spot on now.

Just one architectural detail regarding src/build/expose.ts:

Currently, the changes in src/build/expose.ts are actually dead code because:

1. deepClone returns early on o.signature and never traverses down into param objects.
2. In filterUnknownTypeFromSignature, param.push({ ...p, type: flattenType(filtered) }) spreads p (the original param) rather than preserving filtered[0].additionalTypes.

The reason the baselines generated correctly is actually due to filter((t) => isKnownType(t)) in src/build/emitter.ts.

To clean this up, we have two options:

• Option 1 (Recommended): Make expose.ts actually handle additionalTypes on parameters:

  // In filterUnknownTypeFromSignature in src/build/expose.ts
  const additionalTypes = filterAdditionalTypes(p.additionalTypes, unexposedTypes);
  param.push({
    ...p,
    type: flattenType(filtered),
    additionalTypes: additionalTypes?.length ? additionalTypes : undefined,
  });

  (and remove the unreachable if (o.additionalTypes) at the top of deepClone).
• Option 2: If filtering via isKnownType in emitter.ts is deemed sufficient, revert the changes in src/build/expose.ts completely so we don't leave unused code in expose.ts.