Repository navigation
test(zod): compile generated schema text - #449
Merged
Merged
Conversation
Batch type-check generated schema text while preserving existing regex assertions. Add negative controls for invalid tuple syntax and unresolved type references, and document the compiler-backed checks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Tal Zaccai (TalZaccai)
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strictandnoEmit.getSchemaText()output, and clean up temporary files on success and failure.Context
This implements the compiler-validation suggestion from the review of #445. It is based on
mainand does not duplicate that PR's precedence fix or regression tests. The shared schema helper will also collect and compile #445's new test output when that PR merges.Validation
npm run build: passed.tsc -p test: passed.node --test --test-reporter=spec out\zod.test.js: 51 tests passed, including both negative controls and the batch compilation hook.git diff --check: passed.Local validation used Windows, TypeScript 7.0.2, and Node 22.18.0. The local Node version is slightly below the package's >=22.19.0 requirement; supported-version CI should still run before merging.