Repository navigation
fix(program): check own properties without calling instance methods - #448
Draft
JOJO (moneymaker26754-crypto) wants to merge 1 commit into
Draft
JOJO (moneymaker26754-crypto) wants to merge 1 commit into
JOJO (moneymaker26754-crypto) wants to merge 1 commit into
Conversation
|
JOJO (@moneymaker26754-crypto) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
robgruen
requested changes
Oct 15, 2026
robgruen
left a comment
Contributor
There was a problem hiding this comment.
Can we add a null-prototype literal without a hasOwnProperty so the missing-method scenario is it's own test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createModuleTextFromProgramandevaluateJsonProgramthrowTypeErrorwhen an ordinary literal argument contains ahasOwnPropertydata field. Null-prototype call or argument objects fail similarly.Use
Object.prototype.hasOwnProperty.callin the seven program-shape checks, following the existing function-name guard. Four regressions cover generation and evaluation for both input shapes, including the unchanged argument passed to the host callback. Existing unsafe function-name and result-reference tests still pass. Related merged PR #394 handles function names rather than these literal argument fields.Validation: the four new tests fail on the unchanged source, then
npm testpasses all 117 tests after the fix.npm run build-allpasses for the package and examples. This is offline validation and requires no LLM API key.Setup note: ordinary
npm cifailed in the existing prepare step because examples were built before the root package. Validation usednpm ci --ignore-scripts, thennpm testto build the root package, followed bynpm run build-all. No scripts or dependencies were changed.AI-assisted draft with regression evidence; human review and refinement are pending.