fix(dataset): handle plot for dataset with incorrect parameter data#8080
Merged
einsmein merged 5 commits intomicrosoft:mainfrom Apr 29, 2026
Merged
fix(dataset): handle plot for dataset with incorrect parameter data#8080einsmein merged 5 commits intomicrosoft:mainfrom
einsmein merged 5 commits intomicrosoft:mainfrom
Conversation
jenshnielsen
approved these changes
Apr 29, 2026
Collaborator
jenshnielsen
left a comment
There was a problem hiding this comment.
Looks good. Perhaps we should add a changelog entry
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8080 +/- ##
=======================================
Coverage 70.59% 70.60%
=======================================
Files 333 333
Lines 32494 32502 +8
=======================================
+ Hits 22940 22947 +7
- Misses 9554 9555 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies
plot_datasetto handle dataset with incorrect parameter data.When dataset is somehow exported incorrectly, such that
get_parameter_datashows setpoints and dependent params as{ "dep": {"dep": [...], "index": [...]}, "setpoint": {"setpoint": [...], "index": [...]}, }instead of
{"dep" {"dep": [...], "setpoint": [...]}}plot_datasetfunction previously throws aKeyError.(Specifically, we see this when a dataset with unsorted setpoint was exported to netcdf with flag
use_multi_index="always".)