Repository navigation
FIX: fold non-ASCII case in the seed value search - #3665
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Conversation
SQLite lower() only folds ASCII, so a stored value like CAFE with an accent was found by an exact-case search but missed by a lowercase one. The search now folds the column with the Unicode-aware UnicodeLower used by the harm category filters and folds the pattern in Python. Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3664
value_searchis documented to match stored values containing the text while ignoring case, but on SQLite the filter compiled tolower(value) LIKE lower(pattern)and SQLite'slower()only folds ASCII letters. A seed stored asCAFÉ au lait tacticswas found by searchingCAFÉbut missed by searchingcafé, while the same data matched both on Azure SQL.The search now folds the column with the existing Unicode-aware
UnicodeLower(the same machinery the harm category filters already use for exactly this reason) and folds the pattern in Python, so both backends apply the same folding. Wildcard escaping is unchanged.Tests and Documentation
Added a regression next to the harm filter's non-ASCII folding test, covering the accented pair in both directions plus an escaped wildcard value. It fails on main and passes with the change. The full memory interface suite passes (759 tests) and ruff is clean.
No documentation change needed, so I did not run JupyText.