Skip to content

fix: make repeat token dispatch exhaustive #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Roman Lutz (romanlutz) merged 5 commits into from
Oct 31, 2026
Merged

fix: make repeat token dispatch exhaustive #3654

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ec0707
fix(converter): make repeat token dispatch exhaustive
huong8373tt-beep Oct 29, 2026
6e1690b
Merge branch 'main' into fix/p311-03-repeat-token-dispatch
romanlutz Oct 30, 2026
dda26d8
Merge branch 'main' into fix/p311-03-repeat-token-dispatch
huong8373tt-beep Oct 30, 2026
0a05cb3
test: exclude unreachable repeat token fallback from coverage
huong8373tt-beep Oct 30, 2026
4c2f99a
Merge branch 'main' into fix/p311-03-repeat-token-dispatch
romanlutz Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pyrit/converter/repeat_token_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@
# Licensed under the MIT license.

import re
from typing import Literal
from typing import Literal, assert_never

from pyrit.converter.converter import Converter, ConverterResult
from pyrit.models import ComponentIdentifier, PromptDataType

TokenInsertMode = Literal["split", "prepend", "append", "repeat"]


class RepeatTokenConverter(Converter):
"""
Expand Down Expand Up @@ -35,7 +37,7 @@ def __init__(
*,
token_to_repeat: str,
times_to_repeat: int,
token_insert_mode: Literal["split", "prepend", "append", "repeat"] | None = None,
token_insert_mode: TokenInsertMode | None = None,
) -> None:
"""
Initialize the converter with the specified token, number of repetitions, and insertion mode.
Expand Down Expand Up @@ -92,6 +94,8 @@ def insert(text: str) -> list[str]:
return ["", ""]

self.insert = insert
case _: # pragma: no cover - mode validation above narrows this to TokenInsertMode.
assert_never(mode)
Comment thread
romanlutz marked this conversation as resolved.
Resolved

def _build_identifier(self) -> ComponentIdentifier:
"""
Expand Down
Loading