Skip to content

FIX: restart finding evidence pagination on each opening - #3633

Open
Manohar Paturi (ManoharPaturi) wants to merge 2 commits into
microsoft:mainfrom
ManoharPaturi:fix/finding-evidence-dialog-stale-offset
Open

Manohar Paturi (ManoharPaturi) wants to merge 2 commits into
microsoft:mainfrom
ManoharPaturi:fix/finding-evidence-dialog-stale-offset

Conversation

@ManoharPaturi

@ManoharPaturi Manohar Paturi (ManoharPaturi) commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fixes #3632

The reopen reset cleared the selection, notice, and attach error but left the pagination offset and title filter in place, so a later opening fetched the previous opening's page and search and could show an empty list for an operation that has findings. The reopen reset now also returns to the first page with an empty filter, matching what the dialog already does when the operation changes or a search is typed.

Tests and Documentation

Added a regression test that pages forward, cancels, reopens, and asserts the findings request goes back to offset 0 with an empty title. It fails on main and passes with the change. The full dialog suite passes (23 tests) and tsc is clean.

No documentation change needed, so I did not run JupyText.

The regression never typed a search, so it passed with the title reset removed from the reopening effect. The test now enters a search, cancels, reopens, and asserts both the empty input and the unfiltered request, and it fails if either half of the reset is removed.

Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 1, 2026 05:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@ManoharPaturi

Copy link
Copy Markdown
Contributor Author

Good catch, and I confirmed the gap first: with setTitle('') removed from the reopening reset, the old test still passed, exactly as you verified. The test in 90c354f now types Proof after paging forward, asserts the filtered request goes out with title: 'Proof', then cancels, reopens, and asserts both that the search input is empty and that the request returns to {limit: 20, offset: 0, title: ''}. The pagination assertion stays as before.

Both halves are now protected independently: removing setOffset(0) fails it at the request assertion, and removing setTitle('') fails it at the empty input assertion, which I checked by mutation before pushing. The dialog suite passes at 23 tests and tsc is clean.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finding evidence dialog reopens at the previous opening's findings page and search

3 participants