FIX: Improve selected configuration path contrast - #2643
Merged
Roman Lutz (romanlutz) merged 5 commits intoSep 15, 2026
Merged
Roman Lutz (romanlutz) merged 5 commits into
Roman Lutz (romanlutz) merged 5 commits into
Conversation
Inherit the primary button foreground so selected paths follow system colors across hover, pressed, and focus states. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Roman Lutz (romanlutz)
approved these changes
Sep 14, 2026
Roman Lutz (romanlutz)
enabled auto-merge
September 14, 2026 21:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2641.
The selected
EditorWorkspacenavigation item uses a primary brand background, but its secondary path retainedcolorNeutralForeground3. ApplycolorNeutralForegroundOnBrandonly to the selected item's secondary text while preserving the muted color for unselected items.With the Fluent UI 9.74.7 web themes, the selected-state contrast is now:
#ffffffon#0f6cbd— 5.38:1#ffffffon#115ea3— 6.66:1Both exceed the 4.5:1 requirement.
Tests and Documentation
npm run lintnpm run type-checknpm run buildnpm test -- --runInBand src/components/Configuration/Configuration.test.tsx— 10 passednpm test -- --runInBand --testPathIgnorePatterns=LabelsBar.test.tsx— 1,346 passedThe full suite passed 1,423 of 1,424 tests. The remaining existing
LabelsBarclick-away test failed independently when rerun alone and does not import or exerciseEditorWorkspace. No documentation change is needed for this visual bug fix.