FIX Honor score feedback and handle zero-vector similarity - #2403
Open
Roman Lutz (romanlutz) wants to merge 1 commit into
Open
FIX Honor score feedback and handle zero-vector similarity#2403Roman Lutz (romanlutz) wants to merge 1 commit into
Roman Lutz (romanlutz) wants to merge 1 commit into
Conversation
Handle zero-vector cosine similarity deterministically and migrate deprecated shell examples to scenario-results. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
use_score_as_feedback=Falsewas preserved in attack configuration but ignored by Crescendo and Tree of Attacks with Pruning. This change keeps prior target-response context available to the adversarial model while suppressing score values and rationales; TAP also skips the unnecessary score lookup. Default score-feedback behavior remains unchanged.The audit also found that cosine similarity returned
nanfor zero vectors, so zero-norm comparisons now return0.0. Stale PyRIT shell examples are migrated from the deprecatedprint-scenarioalias toscenario-resultsand updated to match the current history output.This does not change Crescendo refusal, backtracking, or terminal success semantics.
Tests and Documentation
doc/scanner/2_pyrit_shell.md; JupyText is not applicable to this Markdown-only documentation change.