MAINT: Consolidate OpenAI response handling - #2381
Open
Roman Lutz (romanlutz) wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
| class OpenAIResponseAdapter(Protocol[ResponseT]): | ||
| """The response-format contract used by ``OpenAITarget``.""" | ||
|
|
||
| def is_content_filter(self, *, response: ResponseT) -> bool: |
Contributor
There was a problem hiding this comment.
nit: this makes it seem like we're detecting whether the repsonse is a content filter vs whether it was filtered so maybe rename to is_content_filtered
| bool: True if content filter detected, False otherwise. | ||
| """ | ||
| return False | ||
| return self._response_adapter.is_content_filter(response=response) |
Contributor
There was a problem hiding this comment.
should we just eliminate these functions in favor of creating the adapter objects ?
| ... | ||
|
|
||
|
|
||
| class NoOpOpenAIResponseAdapter: |
Contributor
There was a problem hiding this comment.
this noop class seems weird to me. can we just make the OpenAIResponseAdapter be a base class (rathter than a protocol) with this functionality ?
Contributor
|
should we also include OpenAI video ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OpenAI Chat Completions, Completions, and Responses targets previously implemented response validation, filtering, truncation detection, partial-content extraction, and metadata capture across multiple target classes. This made behavior harder to compare and maintain as the API formats evolved.
This change introduces a small typed response-adapter seam with dedicated adapters for each wire format and a no-op default for other OpenAI targets. Existing protected target hooks remain compatibility delegates, including subclass truncation overrides. The consolidation preserves each format's existing behavior, including legacy Completions semantics, content-filter handling, partial output, stop reasons, token usage, and graceful truncated responses.
Tests and Documentation
git diff --check.