FIX: show initializer create errors inside the open dialog - #2370
Merged
hannahwestra25 merged 2 commits intoAug 13, 2026
Conversation
varunj-msft
approved these changes
Aug 12, 2026
Roman Lutz (romanlutz)
approved these changes
Aug 13, 2026
hannahwestra25
force-pushed
the
hannahwestra25-fix-initializer-create-errors-in-dialog
branch
2 times, most recently
from
August 13, 2026 15:27
ddc0f82 to
d19886f
Compare
When POST /api/initializers/settings rejects a create request, the error
was only shown on the page behind the modal. Now the error is surfaced
inside the active dialog via an externalError prop on
InitializerParametersDialog.
- Change onAdd return type from Promise<boolean> to
Promise<{ added: boolean; error?: string }> so the error message
propagates back to the dialog layer
- Add externalError prop to InitializerParametersDialog to display
server errors alongside validation errors
- Add addError state in AdditionalInitializers to track and clear
server errors
- Add tests for both the dialog prop and the integration flow
Fixes microsoft#2346
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
hannahwestra25
force-pushed
the
hannahwestra25-fix-initializer-create-errors-in-dialog
branch
from
August 13, 2026 15:42
d19886f to
61e8445
Compare
hannahwestra25
deleted the
hannahwestra25-fix-initializer-create-errors-in-dialog
branch
August 13, 2026 17:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When POST /api/initializers/settings rejects a create request, the error was only shown on the page behind the modal. Now the error is surfaced inside the active dialog via an externalError prop on InitializerParametersDialog.
Fixes #2346