Rename BASELINE_POLICY to BASELINE_ATTACK_POLICY for clarity#1763
Merged
hannahwestra25 merged 3 commits intoMay 20, 2026
Merged
Conversation
Addresses review feedback from PR microsoft#1760 requesting a more descriptive name for the class variable that controls baseline attack inclusion. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rlundeen2
approved these changes
May 20, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hannahwestra25
force-pushed
the
hannahwestra25/rename-baseline-policy
branch
from
163337a to
2695990
Compare
romanlutz
approved these changes
May 20, 2026
Renames the enum class to match the BASELINE_ATTACK_POLICY attribute. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames
BASELINE_POLICYtoBASELINE_ATTACK_POLICYacross the codebase for clarity.Addresses review feedback requesting a more descriptive name. The word 'baseline' is overloaded; adding 'ATTACK' makes it clear this controls inclusion of the baseline attack (
PromptSendingAttack) rather than some other baseline concept.Changes
pyrit/scenario/core/scenario.py- class variable + all references in docstrings/logicpyrit/scenario/scenarios/benchmark/adversarial.py- subclass override.github/instructions/scenarios.instructions.md- contributor docsdoc/code/scenarios/0_scenarios.py+.ipynb- walkthrough docsTesting
Pure rename; no behavioral changes.